Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bean that has a bound interceptor must not declare final methods #5108

Merged
merged 1 commit into from
Nov 1, 2019
Merged

Bean that has a bound interceptor must not declare final methods #5108

merged 1 commit into from
Nov 1, 2019

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Nov 1, 2019

  • otherwise a deployment exception is thrown
  • final methods declared on bean classes that require client proxies are
    ignored though

@mkouba mkouba added this to the 0.28.0 milestone Nov 1, 2019
@mkouba mkouba requested review from manovotn and geoand November 1, 2019 08:55
geoand
geoand approved these changes Nov 1, 2019
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geoand geoand mentioned this pull request Nov 1, 2019
Merged
@mkouba
Copy link
Contributor Author

mkouba commented Nov 1, 2019

Ach, "Imports are not sorted..." again...

@gsmet
Copy link
Member

gsmet commented Nov 1, 2019

Is it supposed to replace #5104 ?

@geoand
Copy link
Contributor

geoand commented Nov 1, 2019

No, it's a prerequisite. I have rebased that PR onto this one locally so once this one is ready, I'll force push the to #5104

@mkouba mkouba force-pushed the subclass-disallow-final-methods branch from 23434e9 to 46232cd Compare November 1, 2019 09:52
@mkouba mkouba force-pushed the subclass-disallow-final-methods branch 2 times, most recently from ebf00ee to 4951446 Compare November 1, 2019 11:42
@mkouba
Copy link
Contributor Author

mkouba commented Nov 1, 2019

@gsmet added FinalNonInterceptedMethodTest and changed the wording a little...

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 1, 2019
@manovotn
Copy link
Contributor

manovotn commented Nov 1, 2019

Imports are not sorted
@mkouba looks like you've commited another sorting sin ;)

@geoand
Copy link
Contributor

geoand commented Nov 1, 2019

Imports again :P

@mkouba
Copy link
Contributor Author

mkouba commented Nov 1, 2019

Eh, I need to import more coffee. Or maybe start doing something meaningful ;-).

@mkouba
Intercepted methods of a bean may not be declared final
e08e3d8 
- otherwise a deployment exception is thrown
- final methods declared on bean classes that require client proxies are
ignored though
@mkouba mkouba force-pushed the subclass-disallow-final-methods branch from 4951446 to e08e3d8 Compare November 1, 2019 12:39
@gsmet gsmet merged commit bf45745 into quarkusio:master Nov 1, 2019
@gsmet
Copy link
Member

gsmet commented Nov 1, 2019

And merged, thanks @mkouba and @geoand !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@manovotn manovotn manovotn approved these changes

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
0.28.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mkouba @gsmet @geoand @manovotn