Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Support both GraalVM 19.2.1 and 19.3.1 - Duplicate targeting GraalVM 19.3.1-java8 #6594

Conversation

gwenneg
Copy link
Member

@gwenneg gwenneg commented Jan 16, 2020

Duplicate of #6574 with a different GraalVM target: 19.3.1-java8.

This is a control PR that is not meant to be merged and will be closed as soon as #6574 is merged.

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just making sure it won't be merged by accident :)

@geoand
Copy link
Contributor

geoand commented Jan 17, 2020

The failure should be fixed by #6597

@geoand
Copy link
Contributor

geoand commented Jan 17, 2020

I pushed the Netty substitution commit, let's see if CI passes

@gwenneg
Copy link
Member Author

gwenneg commented Jan 17, 2020

All natives tests are green 🎉

@geoand
Copy link
Contributor

geoand commented Jan 17, 2020

AWESOME job @gwenneg !

@geoand
Copy link
Contributor

geoand commented Jan 17, 2020

This PR did what it was meat to do which was to test GraalVM 19.3.1. It can now rest in piece :)

@geoand geoand closed this Jan 17, 2020
@gwenneg gwenneg deleted the issue-6483-support-graalvm-19.2.1-and-19.3.1-ci-test branch January 17, 2020 21:48
@gsmet gsmet added the triage/invalid This doesn't seem right label Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants