-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Netty substitution that addresses Camel Quarkus issue #6597
Conversation
cc @lburgazzoli |
we'll retest the quarkus side once merged |
I am also linking the GraalVM issue that was opened to make tracking down such issues easier the future: oracle/graal#2076 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@geoand you're my hero :).
I added a very small comment, otherwise let's merge that one ASAP.
extensions/netty/runtime/src/main/java/io/quarkus/netty/runtime/graal/NettySubstitutions.java
Outdated
Show resolved
Hide resolved
@gsmet I committed your suggestion, thanks for spotting the mistake! |
|
…e/graal/NettySubstitutions.java Co-Authored-By: Guillaume Smet <[email protected]>
#6594 also tested this with GraalVM 19.3.1 (and so did I locally) |
The CI failure is a flaky test that has nothing to do with this PR (and is being tracked by @sberyozkin). I'm gonna merge once the other tests complete |
Addresses the issue in Camel Quarkus with GraalVM 19.3.1 (it only appears in that version) where the native image generation fails with:
Both the root cause tracking and the substitution were provided by @dmlloyd (hence the author of the commit)