fix compiler errors in kafka-streams guide #8520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jharting
force-pushed
the
kafka-streams-guide-fix-compiler-errors
branch
from
ac30ac6 to
45a6a8f
Compare
gsmet
requested changes
Apr 10, 2020
| @@ -116,7 +116,8 @@ import java.util.stream.Collectors; | |||
| import javax.enterprise.context.ApplicationScoped; | |||
|
|
|||
| import org.eclipse.microprofile.reactive.messaging.Outgoing; | |||
| import org.jboss.logging.Logger; | |||
| import org.slf4j.Logger; | |||
| import org.slf4j.LoggerFactory; | |||
There was a problem hiding this comment.
Hmmm, no this is not good. We want to use JBoss Logging.
|
@cescoffier I let you have a look at that one? Looks related to your Kafka changes. |
|
Thanks btw! |
|
/cc @gunnarmorling too |
|
LGTM, apart from the logging change. Actual example needs updating, too? |
|
@gunnarmorling this PR is aligning the docs with what's in the quickstart https://github.com/quarkusio/quarkus-quickstarts/blob/master/kafka-streams-quickstart/producer/src/main/java/org/acme/kafka/streams/producer/generator/ValuesGenerator.java#L16 |
|
Yes, the quickstart should use JBoss Logging. Can you prepare a PR for the quickstart and adjust this one? Thanks! |
gsmet
approved these changes
Apr 14, 2020
|
I pushed a change along those lines and also fixed the quickstart. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.