Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compiler errors in kafka-streams guide #8520

Merged
merged 2 commits into from
Apr 14, 2020
Merged

fix compiler errors in kafka-streams guide #8520

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45a6a8f
fix compiler errors in kafka-streams guide
jharting Apr 10, 2020
09e7859
Switch to JBoss Logging in Kafka Streams guide
gsmet Apr 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions docs/src/main/asciidoc/kafka-streams.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,8 @@ import java.util.stream.Collectors;
import javax.enterprise.context.ApplicationScoped;

import org.eclipse.microprofile.reactive.messaging.Outgoing;
import org.jboss.logging.Logger;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, no this is not good. We want to use JBoss Logging.


import io.reactivex.Flowable;
import io.smallrye.reactive.messaging.kafka.KafkaRecord;
Expand All @@ -130,7 +131,7 @@ import io.smallrye.reactive.messaging.kafka.KafkaRecord;
@ApplicationScoped
public class ValuesGenerator {

private static final Logger LOG = Logger.getLogger(ValuesGenerator.class);
private static final Logger LOG = LoggerFactory.getLogger(ValuesGenerator.class);

private Random random = new Random();

Expand Down Expand Up @@ -167,7 +168,7 @@ public class ValuesGenerator {
@Outgoing("weather-stations") // <3>
public Flowable<KafkaRecord<Integer, String>> weatherStations() {
List<KafkaRecord<Integer, String>> stationsAsJson = stations.stream()
.map(s -> KafkaMessage.of(
.map(s -> KafkaRecord.of(
s.id,
"{ \"id\" : " + s.id +
", \"name\" : \"" + s.name + "\" }"))
Expand Down Expand Up @@ -297,6 +298,7 @@ import java.math.RoundingMode;

import io.quarkus.runtime.annotations.RegisterForReflection;

@RegisterForReflection
public class Aggregation {

public int stationId;
Expand Down