refactor: remove quasar typing import from tsconfig preset #10355
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
Users will need to create this file into their own project to compensate these changes.We could automatically generate it as we do with flags, but the same problems of feature flags will apply (you need to run
quasar dev/build
to generate it).We could also keep this on hold until Qv3, but since every TS upgrade has breaking change upgrades anyway (but only at compile time), I think we can apply this now anyway or while upgrading TS to the next minor version and ask people to perform the needed steps manuallyWe could also leave
/// <reference types="@quasar/app" />
intoquasar
typings as a fallback for existing projects, which almost certaintly already import something from quasar into their code, meaning the preset change won't affect themWe can then remove the reference when releasing Qv3
EDIT: updated the PR to remove the breaking change and postpone it to Qv3 release, left a comment into the code explaining the situation
The PR fulfills these requirements:
dev
branch (orv[X]
branch)fix: #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
See quasarframework/quasar-starter-kit#162 as why this has been proposed
The main reason is to make TS automatically include
@types/*
packages again, which right now must be done by hand as we usetypes
optionThat PR should be merged and pushed into master before this one
This PR will then require a release of both
quasar
and@quasar/app
packagesThis PR spawned from some comments into #10277