Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix add deployment channel message #71

Merged

Conversation

epugh
Copy link
Contributor

@epugh epugh commented Apr 21, 2021

This fixes #70. I then went ahead and edited the messages for all the api responses to follow the same structure.

@epugh
Copy link
Contributor Author

epugh commented Apr 21, 2021

I tested this manually.

@epugh
Copy link
Contributor Author

epugh commented Nov 4, 2021

With the suggestion to use the term Rules Collection instead of Deployment Channel, this PR needs updating....

@epugh epugh marked this pull request as draft November 4, 2021 12:48
@pbartusch
Copy link
Collaborator

Hi @epugh , this PR seems to be ready for review. I suggest merging it with #80 within the new smui_v3_13_3 branch.

@pbartusch pbartusch marked this pull request as ready for review January 5, 2022 20:55
@pbartusch pbartusch merged commit 7ae2353 into querqy:master Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confirmation (and error) message in API for creating a Deployment Channel needs updating
2 participants