list terms #2740
Merged
list terms #2740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trinity-1686a
force-pushed
the
trinity--list-terms
branch
from
f86b648 to
6191f7f
Compare
guilload
reviewed
Jan 31, 2023
guilload
approved these changes
Jan 31, 2023
trinity-1686a
force-pushed
the
trinity--list-terms
branch
from
5c81167 to
a1b6762
Compare
guilload
approved these changes
Feb 7, 2023
|
|
||
| // Root list terms API. | ||
| // This RPC identifies the set of splits on which the query should run on, | ||
| // and dispatches the several calls to `LeafListTerm`. |
There was a problem hiding this comment.
Suggested change
| // and dispatches the several calls to `LeafListTerm`. | |
| // and dispatches the several calls to `LeafListTerms `. |
| mut client: SearchServiceClient, | ||
| ) -> crate::Result<LeafListTermsResponse> { | ||
| let response_res = client.leaf_list_terms(request.clone()).await; | ||
| // TODO: implement retry |
There was a problem hiding this comment.
Can you remove this commented code and open an issue?
trinity-1686a
force-pushed
the
trinity--list-terms
branch
from
a8597f3 to
58a8563
Compare
left unimplemented for now
Co-authored-by: Adrien Guillo <[email protected]>
trinity-1686a
force-pushed
the
trinity--list-terms
branch
from
58a8563 to
64a7405
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2567
Description
add a new list_term search, which enumerate terms over a range in the sstable and does not fetch actual documents
How was this PR tested?
basic unit tests where added
TODO
error handling is perfectible/missing, some code (term manipulation) should probably be part of tantivy rather than quickwit