add history file output #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
/azp run |
markkrumholz
reviewed
Sep 8, 2023
There was a problem hiding this comment.
It looks like you have left it up the the user to reduce statistics across MPI ranks, i.e., this has to be handled in their implementation of ComputeStatistics. It seems like this might be an invitation to user confusion. I understand the reason for the decision, since it allows maximum flexibility -- the user may want to reduce in different ways, e.g., computing extrema versus means -- but it seems like it would be good if the comment here included an explicit warning that the user is responsible for implementing MPI reduction in their ComputeStatistics implementation.
BenWibking
commented
Sep 8, 2023
BenWibking
commented
Sep 8, 2023
markkrumholz
approved these changes
Sep 8, 2023
markkrumholz
approved these changes
Sep 8, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 1, 2024
This updates the shock-cloud problem to use a new setup that:
- tracks the cloud center-of-mass frame
- refines so that the cooling length $l_{\text{cool}} = c_s
t_{\text{cool}}$ is resolved with at least 10 cells
- adds derived fields for temperature, entropy, pressure, etc. to the
outputs
- uses the (simplified) Navier-Stokes Characteristic Boundary Conditions
for inflow/outflow on the left/right sides of the box
- adds shock-cloud problem to nightly regression testing
**This PR depends on:**
* #352
* #360
* #363
* #364
* #365
* #366
* #367
* #430
* #581
* #596
* #597
* #598
* #599
* #616
* #645
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a "history file" output, inspired by the same feature in Athena.
This writes a text file named "history.txt" in the simulation working directory with scalar-valued statistics that can be computed by the problem generator in the
RadhydroSimulation<problem_t>::ComputeStatistics()function. The user is responsible for performing any needed MPI reductions inside this function before returning the computed statistics.