add computeVolumeIntegral function #597
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 5 pipeline(s). |
There was a problem hiding this comment.
Doesn't necessarily have to be in this PR, but a very useful enhancement to this might be to let the user optionally provide a number of ghost zones and grow the state variable by that amount. The reason is that right now this will only work for volume integrals of quantities that don't include any derivatives, so for example you couldn't use this to compute the volume integral of vorticity or something like that. It's fine if you don't want to add that now and you want to leave that as an enhancement for a future PR. I just thought I'd mention it as an idea. If you do want to skip it for now, just let me know and I'll approve this as-is.
Let's do that in a future PR. |
This updates the shock-cloud problem to use a new setup that:
- tracks the cloud center-of-mass frame
- refines so that the cooling length $l_{\text{cool}} = c_s
t_{\text{cool}}$ is resolved with at least 10 cells
- adds derived fields for temperature, entropy, pressure, etc. to the
outputs
- uses the (simplified) Navier-Stokes Characteristic Boundary Conditions
for inflow/outflow on the left/right sides of the box
- adds shock-cloud problem to nightly regression testing
**This PR depends on:**
* #352
* #360
* #363
* #364
* #365
* #366
* #367
* #430
* #581
* #596
* #597
* #598
* #599
* #616
* #645
Description
Adds a function that can be used to a compute a volume integral of a user-defined function that takes an Array4 for a box of the
state_new_cc_MultiFab as input.Related issues
N/A
Checklist
Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an
xinside the square brackets[ ]in the Markdown source below:/azp run.