Call API Gateway for search #2253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Base automatically changed from
QF-1276-full-search
to
QF-1272-search-autocomplete
December 1, 2024 17:05
Base automatically changed from
QF-1272-search-autocomplete
to
QF-993-search-as-you-type-POC
December 1, 2024 17:05
osamasayed
changed the base branch from
QF-993-search-as-you-type-POC
to
testing
osamasayed
changed the base branch from
testing
to
QF-993-search-as-you-type-POC
mohsinayoob
approved these changes
Dec 2, 2024
osamasayed
added a commit
that referenced
this pull request
Feb 17, 2025
* Search as you type POC * Remove comments * QF 1272 search autocomplete (#2250) * Handle search drawer no results * Open commandBar on search page input type * Sync state between search page and command bar initial input * Update styling * QF-1276 full search (#2252) Full search * Fix merge issue * Search UI Updates (#2268) Search UI updates * Updates * Updates * Updates * Move navigation to the bottom * Handle autofill state * Fix navigation * Fix wrong icons * Fix autofill color * Open search drawer when on mobile * Limit quick search results to 10 (#2283) * Call API Gateway for search (#2253) * Handle search drawer no results * Open commandBar on search page input type * Sync state between search page and command bar initial input * Full search * Call API Gateway for search * Close voice search when clicking outside (#2290) * Redirect to full search when pressing enter * Add user selectedTranslations to search query * Add enterKeyHint
osamasayed
added a commit
that referenced
this pull request
Feb 17, 2025
* Search as you type POC * Remove comments * QF 1272 search autocomplete (#2250) * Handle search drawer no results * Open commandBar on search page input type * Sync state between search page and command bar initial input * Update styling * QF-1276 full search (#2252) Full search * Fix merge issue * Search UI Updates (#2268) Search UI updates * Updates * Updates * Updates * Move navigation to the bottom * Handle autofill state * Fix navigation * Fix wrong icons * Fix autofill color * Open search drawer when on mobile * Limit quick search results to 10 (#2283) * Call API Gateway for search (#2253) * Handle search drawer no results * Open commandBar on search page input type * Sync state between search page and command bar initial input * Full search * Call API Gateway for search * Close voice search when clicking outside (#2290) * Redirect to full search when pressing enter * Add user selectedTranslations to search query * Add enterKeyHint
osamasayed
added a commit
that referenced
this pull request
Feb 25, 2025
* Search as you type POC * Remove comments * QF 1272 search autocomplete (#2250) * Handle search drawer no results * Open commandBar on search page input type * Sync state between search page and command bar initial input * Update styling * QF-1276 full search (#2252) Full search * Fix merge issue * Search UI Updates (#2268) Search UI updates * Updates * Updates * Updates * Move navigation to the bottom * Handle autofill state * Fix navigation * Fix wrong icons * Fix autofill color * Open search drawer when on mobile * Limit quick search results to 10 (#2283) * Call API Gateway for search (#2253) * Handle search drawer no results * Open commandBar on search page input type * Sync state between search page and command bar initial input * Full search * Call API Gateway for search * Remove New label from Tajweed colors drawer * Close voice search when clicking outside (#2290) * Redirect to full search when pressing enter * Add Prepare For Ramadan Page (#2297) * Add Prepare For Ramadan Page * Change the route * Add image * Add collapsible reviews section * Add What is Ramadan page (#2299) * Add What is Ramadan page * Update verse styling * Update metadata * test * Remove Onboarding * Add Q & A sharing * Add user selectedTranslations to search query * Add enterKeyHint * test * Updates * Updates * Add share the quran modal * Update styling of about the Quran page * Switch buttons * Updates * Updates * updates * updates * Remove Tarteel voice search (#2328) * Remove Tarteel attribution * Update locales * Fix TS issue * updates * Add donors card * Qf 1034 unified registration (#2323) * test * test * Add logging * Update styling * Update styling * Updates * updates * updates
osamasayed
added a commit
that referenced
this pull request
Feb 25, 2025
* Search as you type POC * Remove comments * QF 1272 search autocomplete (#2250) * Handle search drawer no results * Open commandBar on search page input type * Sync state between search page and command bar initial input * Update styling * QF-1276 full search (#2252) Full search * Fix merge issue * Search UI Updates (#2268) Search UI updates * Updates * Updates * Updates * Move navigation to the bottom * Handle autofill state * Fix navigation * Fix wrong icons * Fix autofill color * Open search drawer when on mobile * Limit quick search results to 10 (#2283) * Call API Gateway for search (#2253) * Handle search drawer no results * Open commandBar on search page input type * Sync state between search page and command bar initial input * Full search * Call API Gateway for search * Remove New label from Tajweed colors drawer * Close voice search when clicking outside (#2290) * Redirect to full search when pressing enter * Add Prepare For Ramadan Page (#2297) * Add Prepare For Ramadan Page * Change the route * Add image * Add collapsible reviews section * Add What is Ramadan page (#2299) * Add What is Ramadan page * Update verse styling * Update metadata * test * Remove Onboarding * Add Q & A sharing * Add user selectedTranslations to search query * Add enterKeyHint * test * Updates * Updates * Add share the quran modal * Update styling of about the Quran page * Switch buttons * Updates * Updates * updates * updates * Remove Tarteel voice search (#2328) * Remove Tarteel attribution * Update locales * Fix TS issue * updates * Add donors card * Qf 1034 unified registration (#2323) * test * test * Add logging * Update styling * Update styling * Updates * updates * updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #QF-1115
This PR calls the search service via the API gateway instead of directly.