Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit quick search results to 10 #2283

Conversation

osamasayed
Copy link
Member

Summary

Fixes #QF-1625

Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
quran-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 0:13am

@osamasayed osamasayed merged commit c073a30 into QF-993-search-as-you-type-POC Jan 23, 2025
5 checks passed
@osamasayed osamasayed deleted the QF-1625-limit-quick-search-results-to-10 branch January 23, 2025 02:47
osamasayed added a commit that referenced this pull request Feb 17, 2025
* Search as you type POC

* Remove comments

* QF 1272 search autocomplete (#2250)

* Handle search drawer no results

* Open commandBar on search page input type

* Sync state between search page and command bar initial input

* Update styling

* QF-1276 full search (#2252)

Full search

* Fix merge issue

* Search UI Updates (#2268)

Search UI updates

* Updates

* Updates

* Updates

* Move navigation to the bottom

* Handle autofill state

* Fix navigation

* Fix wrong icons

* Fix autofill color

* Open search drawer when on mobile

* Limit quick search results to 10 (#2283)

* Call API Gateway for search (#2253)

* Handle search drawer no results

* Open commandBar on search page input type

* Sync state between search page and command bar initial input

* Full search

* Call API Gateway for search

* Close voice search when clicking outside (#2290)

* Redirect to full search when pressing enter

* Add user selectedTranslations to search query

* Add enterKeyHint
osamasayed added a commit that referenced this pull request Feb 17, 2025
* Search as you type POC

* Remove comments

* QF 1272 search autocomplete (#2250)

* Handle search drawer no results

* Open commandBar on search page input type

* Sync state between search page and command bar initial input

* Update styling

* QF-1276 full search (#2252)

Full search

* Fix merge issue

* Search UI Updates (#2268)

Search UI updates

* Updates

* Updates

* Updates

* Move navigation to the bottom

* Handle autofill state

* Fix navigation

* Fix wrong icons

* Fix autofill color

* Open search drawer when on mobile

* Limit quick search results to 10 (#2283)

* Call API Gateway for search (#2253)

* Handle search drawer no results

* Open commandBar on search page input type

* Sync state between search page and command bar initial input

* Full search

* Call API Gateway for search

* Close voice search when clicking outside (#2290)

* Redirect to full search when pressing enter

* Add user selectedTranslations to search query

* Add enterKeyHint
osamasayed added a commit that referenced this pull request Feb 25, 2025
* Search as you type POC

* Remove comments

* QF 1272 search autocomplete (#2250)

* Handle search drawer no results

* Open commandBar on search page input type

* Sync state between search page and command bar initial input

* Update styling

* QF-1276 full search (#2252)

Full search

* Fix merge issue

* Search UI Updates (#2268)

Search UI updates

* Updates

* Updates

* Updates

* Move navigation to the bottom

* Handle autofill state

* Fix navigation

* Fix wrong icons

* Fix autofill color

* Open search drawer when on mobile

* Limit quick search results to 10 (#2283)

* Call API Gateway for search (#2253)

* Handle search drawer no results

* Open commandBar on search page input type

* Sync state between search page and command bar initial input

* Full search

* Call API Gateway for search

* Remove New label from Tajweed colors drawer

* Close voice search when clicking outside (#2290)

* Redirect to full search when pressing enter

* Add Prepare For Ramadan Page (#2297)

* Add Prepare For Ramadan Page

* Change the route

* Add image

* Add collapsible reviews section

* Add What is Ramadan page (#2299)

* Add What is Ramadan page

* Update verse styling

* Update metadata

* test

* Remove Onboarding

* Add Q & A sharing

* Add user selectedTranslations to search query

* Add enterKeyHint

* test

* Updates

* Updates

* Add share the quran modal

* Update styling of about the Quran page

* Switch buttons

* Updates

* Updates

* updates

* updates

* Remove Tarteel voice search (#2328)

* Remove Tarteel attribution

* Update locales

* Fix TS issue

* updates

* Add donors card

* Qf 1034 unified registration (#2323)

* test

* test

* Add logging

* Update styling

* Update styling

* Updates

* updates

* updates
osamasayed added a commit that referenced this pull request Feb 25, 2025
* Search as you type POC

* Remove comments

* QF 1272 search autocomplete (#2250)

* Handle search drawer no results

* Open commandBar on search page input type

* Sync state between search page and command bar initial input

* Update styling

* QF-1276 full search (#2252)

Full search

* Fix merge issue

* Search UI Updates (#2268)

Search UI updates

* Updates

* Updates

* Updates

* Move navigation to the bottom

* Handle autofill state

* Fix navigation

* Fix wrong icons

* Fix autofill color

* Open search drawer when on mobile

* Limit quick search results to 10 (#2283)

* Call API Gateway for search (#2253)

* Handle search drawer no results

* Open commandBar on search page input type

* Sync state between search page and command bar initial input

* Full search

* Call API Gateway for search

* Remove New label from Tajweed colors drawer

* Close voice search when clicking outside (#2290)

* Redirect to full search when pressing enter

* Add Prepare For Ramadan Page (#2297)

* Add Prepare For Ramadan Page

* Change the route

* Add image

* Add collapsible reviews section

* Add What is Ramadan page (#2299)

* Add What is Ramadan page

* Update verse styling

* Update metadata

* test

* Remove Onboarding

* Add Q & A sharing

* Add user selectedTranslations to search query

* Add enterKeyHint

* test

* Updates

* Updates

* Add share the quran modal

* Update styling of about the Quran page

* Switch buttons

* Updates

* Updates

* updates

* updates

* Remove Tarteel voice search (#2328)

* Remove Tarteel attribution

* Update locales

* Fix TS issue

* updates

* Add donors card

* Qf 1034 unified registration (#2323)

* test

* test

* Add logging

* Update styling

* Update styling

* Updates

* updates

* updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants