Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Main thread] Dev status #81

Closed
qwreey opened this issue Apr 27, 2023 · 11 comments
Closed

[Main thread] Dev status #81

qwreey opened this issue Apr 27, 2023 · 11 comments
Assignees

Comments

@qwreey
Copy link
Owner

qwreey commented Apr 27, 2023

Bugs that i can fix now

Fix fade effect (Fixed)

#19

Event notify::vscrollbar-visible can follow scrollbar visible status

image

r(57).connect("notify::vscrollbar-visible",()=>log("QLOG vscrollbar-visible"))

https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/fc587b3e0c08b09e0121bc2dd319cef6cdb4c340/src/st/st-scroll-view.c#L706

and we can update overlay_scrollbars to fix fade effect issue

image

Quick toggle attached to the bottom of qs (Fixed)

If some extensions add a quick toggle after the qsTweaks extension is loaded, that quick toggle will be attached to bottom of the qs Panel ![image](https://user-images.githubusercontent.com/46598063/234783277-070c9193-e13c-4f0c-a19b-da50948980de.png)

We can use actor-removed actor-added on st-widget to check children added / removed
image

Reappearing hidden buttons (Fixed)

#73 #65

notify::mapped can check menu is opened, closed
r(0).connect("notify::mapped",()=>log("QLOG asdf"))
image

We can recheck children and update visible status when menu opened

Other

I can implement

  1. [Feature request] Option to add a row to display Date and time #67
  2. Remove some devices on Audio output/input selector #45 ?Maybe?
  3. Quick toggles order #62 ?Maybe?
  4. [Suggestion] Add night light slider #4 ?Maybe?

Bug that i can't reproduce, fix

  1. Volume mixer multiple instances swamp quick settings #63
  2. After suspending session, output chooser no longer presents list of available output device #68

Bug that I found

  1. weird position of notification time
    image
@qwreey qwreey pinned this issue Apr 27, 2023
@qwreey
Copy link
Owner Author

qwreey commented Apr 28, 2023

Now use GObject.insert_child_at_index which have more performence benefit instead of Me.imports.libs.utility.addChildWithIndex

@qwreey
Copy link
Owner Author

qwreey commented Apr 28, 2023

Feature idea:
gnome unsafe mode quick toggle (for gnome dev) (implemented)

@qwreey
Copy link
Owner Author

qwreey commented Apr 28, 2023

Now, using busctl --user call org.gnome.Shell /org/gnome/Shell org.gnome.Shell Eval s 'Meta.restart("Restarting…", global.context)' to reload gnome shell in make dev. this is would better for speed, and stability

One of disadvantages is busctl to gnome requires gnome unsafe mode. which grant others to change gnome behavior

@qwreey
Copy link
Owner Author

qwreey commented Apr 28, 2023

Now, Extension loader no longer uses GLib.timeout_add. Instead, just init features immediately.

Because timeout make errors invisible, debug harder

@qwreey
Copy link
Owner Author

qwreey commented Apr 29, 2023

datemenu-fix-weather-widget no longer used, i'll remove

@qwreey
Copy link
Owner Author

qwreey commented Apr 29, 2023

Fixed #19

@Ridhubharan
Copy link

The quick toggle for "Caffeine" gnome extension appearing below the media player is fixed by the developer.

@qwreey
Copy link
Owner Author

qwreey commented May 1, 2023

The developer fixed the quick toggle for "Caffeine" gnome extension appearing below the media player.

in eonpatapon/gnome-shell-extension-caffeine#250 PR, it was fixed

But, anyway, QSTweaks doesn't update it self index, that means if any extension, not only Caffeine add QSToggle, it may appear below the notification box

@qwreey qwreey self-assigned this May 2, 2023
@qwreey
Copy link
Owner Author

qwreey commented May 2, 2023

Old, have no updates

2023-05-03.01-11-49.mp4

New, have update on menu open

2023-05-03.01-13-10.mp4

Now, as I add menuOpenTracker, it updates ordering on the menu opens. next step is updating buttons visibility

@qwreey
Copy link
Owner Author

qwreey commented May 2, 2023

Feature idea:

gnome unsafe mode quick toggle (for gnome dev)

image

@qwreey
Copy link
Owner Author

qwreey commented May 2, 2023

Maybe i can fix #63 a bit by adding a scroll

@qwreey qwreey closed this as completed Oct 14, 2023
@qwreey qwreey unpinned this issue Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants