Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tags for a linter that was renamed in transit #1014

Merged
merged 6 commits into from
Mar 28, 2022
Merged

Fix tags for a linter that was renamed in transit #1014

merged 6 commits into from
Mar 28, 2022

Conversation

MichaelChirico
Copy link
Collaborator

Same issue as was caught in #999

@MichaelChirico MichaelChirico mentioned this pull request Mar 28, 2022
Merged
@AshesITR
Copy link
Collaborator

Ditto for expect_s4_class_linter(), which has the s3 version in @evalRd.

@MichaelChirico
Copy link
Collaborator Author

Since conjunct_expectation_linter is renamed in #1011, I'll revert here (it's fixed in that PR already), and just fix expect_s4_class_linter()

AshesITR
AshesITR previously approved these changes Mar 28, 2022
View reviewed changes
@MichaelChirico MichaelChirico merged commit 6ad21a7 into master Mar 28, 2022
@MichaelChirico MichaelChirico deleted the renamed branch March 28, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AshesITR AshesITR AshesITR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelChirico @AshesITR