New stop_paste_linter

[MichaelChirico]

Part of #962

This one could probably go for an improved name as well, but I am consistently stumped here.

[AshesITR]

Maybe call it redundant_paste_linter()? Could also add cat() to the list IINM.

[MichaelChirico]

cat() is slighlty different in that its default is ' ' not ''. but maybe right that using cat's own sep is always preferable to building the string with paste()/paste0().

However I have some gut feeling about why we didn't do that in the first place... can't place exactly why. I will run an updated linter that catches cat() against our internal codebase first to make sure nothing sticks out to me.

[AshesITR]

cat() also auto-collapses using sep. Maybe that's why?

cat(">", letters, "<")
# > a b c d e f g h i j k l m n o p q r s t u v w x y z <

This means cat(paste(">", letters, "<")) is not equivalent to the above, it's cat(">", paste(letters, collapse = " "), "<").

[MichaelChirico]

Good point... so I guess it might be a bit muddled to include that in the same linter.

What about singal_construction_linter? Maybe too broad?

[AshesITR]

Sounds too unfamiliar I think. What about message_linter() or message_construction_linter()?
It should be clear what a message is, plus message() is also linted.
Or condition_message_linter()? Since it lints the message construction of all signalling functions.

BTW: rlang::abort() and colleagues could be added further down the line.

[MichaelChirico]

Sounds too unfamiliar I think. What about message_linter() or message_construction_linter()?

I'd been specifically shying away from "message" because message() is just one part of what's included

Or condition_message_linter()? Since it lints the message construction of all signalling functions.

I think that's probably the way to go. "condition" as an adjective helps make clearer that it's not just message(). will do.

[AshesITR]

LGTM apart from the doc problem.

[AshesITR]

Should we stop() or at least issue a warning() if tags are empty? The "No tags were given" message seems to be too quiet...