Fix NSE in shim_help(package = )

Closes #266

NEWS.md

@@ -1,5 +1,9 @@
 # pkgload (development version)
 
+* Fixed a bug in `shim_help()` where a complex `package = ` argument
+  evaluating to `NULL` would cause an error (#266).
+
+
 # pkgload 1.3.4
 
 * On load, pkgload now sets `PKGLOAD_PARENT_TEMPDIR` to the temporary

R/dev-help.R

@@ -261,11 +261,12 @@ shim_help <- function(topic, package = NULL, ...) {
   package_name <- substitute(package)
   if (is_symbol(package_name)) {
     package_str <- as_string(package_name)
-  } else if (is_null(package_name)) {
-    package_str <- NULL
   } else {
+    # Complex expression, just evaluate it (#266). The value is
+    # injected in `utils::help(package = )` below, causing it to be
+    # interpreted as is.
     package_str <- package
-    package_name <- sym(package)
+    package_name <- package
   }
 
   use_dev <-

tests/testthat/test-help.R

@@ -22,6 +22,12 @@ test_that("shim_help behaves the same as utils::help for nonexistent objects", {
   expect_equal(length(shim_help("foofoo")), 0)
 })
 
+test_that("shim_help works with complex NULL `package = ` argument (#266)", {
+  expect_equal(
+    class(pkgload:::shim_help(list, package = (NULL))),
+    "help_files_with_topic"
+  )
+})
 
 test_that("shim_question behaves the same as utils::? for non-devtools-loaded packages", {
   expect_identical(shim_question(lm)[1], utils::`?`(lm)[1])