Turn on XML_PARSE_HUGE #85
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A quick 'fix' to live dangerously with huge parse stacks.
|
One benefit of the current default is if the XML is it can catch malformed XML and erroring rather than allocating a bunch of memory and crashing. It might be worth keeping the current behavior the default and allowing users to turn on XML_PARSE_HUGE if needed. |
|
I'd have a slight preference towards making this an argument (also needs a news bullet) |
Merged
| @@ -42,15 +42,15 @@ XPtrDoc doc_parse_raw(RawVector x, std::string encoding, | |||
| Rf_length(x), | |||
| base_url == "" ? NULL : base_url.c_str(), | |||
| encoding == "" ? NULL : encoding.c_str(), | |||
| HTML_PARSE_RECOVER | HTML_PARSE_NOERROR | |||
| HTML_PARSE_RECOVER | HTML_PARSE_NOERROR | XML_PARSE_HUGE | |||
There was a problem hiding this comment.
Are you sure XML_PARSE_HUGE is ok?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #70