libxml2 parsing options #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 59.65%@@ master #88 diff @@
==========================================
Files 30 30
Lines 1235 1249 +14
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 733 745 +12
- Misses 502 504 +2
Partials 0 0
|
| @@ -1,5 +1,5 @@ | |||
| Package: xml2 | |||
| Version: 0.1.2.9000 | |||
| Version: 0.1.2.9200 | |||
There was a problem hiding this comment.
BTW I don't normally bother bumping this unless it's needed for a revdep.
There was a problem hiding this comment.
It was bumped by the original upstream commit, but good to know!
jimhester
force-pushed
the
shabbychef-master
branch
from
e70c13d to
3f25fb6
Compare
jimhester
changed the title
|
I ended up exposing all of the libxml2 parsing options to the R side in 3f25fb6. They can be specified as a character vector of options to set. The option descriptions come from http://www.xmlsoft.org/html/libxml-parser.html#xmlParserOption |
|
This looks great |
jimhester
force-pushed
the
shabbychef-master
branch
3 times, most recently
from
e5fc442 to
9b1367d
Compare
A quick 'fix' to live dangerously with huge parse stacks.
jimhester
force-pushed
the
shabbychef-master
branch
from
9b1367d to
26e1043
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #85
Fixes #62, #49