Remove location from scaffolded application #5601
Assignees
Labels
bug
Something is broken or not working as expected
Comments
ytimocin
added a commit
that referenced
this issue
May 25, 2023
# Description Removing location from scaffolded application. `app.bicep` has location but docs don't show location in the `app.bicep`. ## Issue reference Fixes: #5601 ## Checklist Please make sure you've completed the relevant tasks for this PR, out of the following list: * [ ] Code compiles correctly * [ ] Adds necessary unit tests for change * [ ] Adds necessary E2E tests for change * [ ] Unit tests passing * [ ] Extended the documentation / Created issue for it ## Auto-generated summary <!-- GitHub Copilot for docs will auto-generate a summary of the PR --> <!-- copilot:all --> ### <samp>🤖 Generated by Copilot at ea6ec87</samp> ### Summary 🗑️🛠️📝 <!-- 1. 🗑️ - This emoji conveys the idea of removing or deleting something, which is what the first change did by removing an unnecessary field from the `rad-config.yaml` template. 2. 🛠️ - This emoji conveys the idea of fixing or repairing something, which is what the second change did by fixing the comment indentation in the `rad.yaml` template. 3. 📝 - This emoji conveys the idea of writing or editing something, which is what both changes did by modifying the code of the templates. --> Simplified and improved `rad` CLI setup command by removing unused field and fixing comment indentation in config templates. > _`rad-config.yaml`_ > _Simpler and clearer now_ > _Autumn leaves of code_ ### Walkthrough * Remove redundant location field from rad-config.yaml template ([link](https://github.com/project-radius/radius/pull/5600/files?diff=unified&w=0#diff-1b0ac5c011aaaf6673a23365f05fe4d2ebdc793c135984d7b3410e59ef92fa75L33)) * Fix indentation of comment explaining trailing newline in rad.yaml template ([link](https://github.com/project-radius/radius/pull/5600/files?diff=unified&w=0#diff-1b0ac5c011aaaf6673a23365f05fe4d2ebdc793c135984d7b3410e59ef92fa75L46-R49))
lakshmimsft
pushed a commit
that referenced
this issue
May 26, 2023
# Description Removing location from scaffolded application. `app.bicep` has location but docs don't show location in the `app.bicep`. ## Issue reference Fixes: #5601 ## Checklist Please make sure you've completed the relevant tasks for this PR, out of the following list: * [ ] Code compiles correctly * [ ] Adds necessary unit tests for change * [ ] Adds necessary E2E tests for change * [ ] Unit tests passing * [ ] Extended the documentation / Created issue for it ## Auto-generated summary <!-- GitHub Copilot for docs will auto-generate a summary of the PR --> <!-- copilot:all --> ### <samp>🤖 Generated by Copilot at ea6ec87</samp> ### Summary 🗑️🛠️📝 <!-- 1. 🗑️ - This emoji conveys the idea of removing or deleting something, which is what the first change did by removing an unnecessary field from the `rad-config.yaml` template. 2. 🛠️ - This emoji conveys the idea of fixing or repairing something, which is what the second change did by fixing the comment indentation in the `rad.yaml` template. 3. 📝 - This emoji conveys the idea of writing or editing something, which is what both changes did by modifying the code of the templates. --> Simplified and improved `rad` CLI setup command by removing unused field and fixing comment indentation in config templates. > _`rad-config.yaml`_ > _Simpler and clearer now_ > _Autumn leaves of code_ ### Walkthrough * Remove redundant location field from rad-config.yaml template ([link](https://github.com/project-radius/radius/pull/5600/files?diff=unified&w=0#diff-1b0ac5c011aaaf6673a23365f05fe4d2ebdc793c135984d7b3410e59ef92fa75L33)) * Fix indentation of comment explaining trailing newline in rad.yaml template ([link](https://github.com/project-radius/radius/pull/5600/files?diff=unified&w=0#diff-1b0ac5c011aaaf6673a23365f05fe4d2ebdc793c135984d7b3410e59ef92fa75L46-R49)) (cherry picked from commit c715d39)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug information
Steps to reproduce (required)
Run
rad init --devand observe the app.bicep that it creates.Observed behavior (required)
Scaffolded application creates app.bicep which has location property. This should be removed.
Desired behavior (required)
No location property
Workaround (optional)
System information
rad Version (required)
0.21
Operating system (required)
Additional context
AB#8007
The text was updated successfully, but these errors were encountered: