Remove location from scaffolded app #5600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
AaronCrawfis
approved these changes
May 25, 2023
lakshmimsft
approved these changes
May 25, 2023
rynowak
approved these changes
May 25, 2023
Test Results2 731 tests ±0 2 724 ✔️ ±0 1m 54s ⏱️ -9s Results for commit ea6ec87. ± Comparison against base commit 2352ce6. This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both. |
|
For the detailed report, please go to
|
lakshmimsft
pushed a commit
that referenced
this pull request
May 26, 2023
# Description Removing location from scaffolded application. `app.bicep` has location but docs don't show location in the `app.bicep`. ## Issue reference Fixes: #5601 ## Checklist Please make sure you've completed the relevant tasks for this PR, out of the following list: * [ ] Code compiles correctly * [ ] Adds necessary unit tests for change * [ ] Adds necessary E2E tests for change * [ ] Unit tests passing * [ ] Extended the documentation / Created issue for it ## Auto-generated summary <!-- GitHub Copilot for docs will auto-generate a summary of the PR --> <!-- copilot:all --> ### <samp>🤖 Generated by Copilot at ea6ec87</samp> ### Summary 🗑️🛠️📝 <!-- 1. 🗑️ - This emoji conveys the idea of removing or deleting something, which is what the first change did by removing an unnecessary field from the `rad-config.yaml` template. 2. 🛠️ - This emoji conveys the idea of fixing or repairing something, which is what the second change did by fixing the comment indentation in the `rad.yaml` template. 3. 📝 - This emoji conveys the idea of writing or editing something, which is what both changes did by modifying the code of the templates. --> Simplified and improved `rad` CLI setup command by removing unused field and fixing comment indentation in config templates. > _`rad-config.yaml`_ > _Simpler and clearer now_ > _Autumn leaves of code_ ### Walkthrough * Remove redundant location field from rad-config.yaml template ([link](https://github.com/project-radius/radius/pull/5600/files?diff=unified&w=0#diff-1b0ac5c011aaaf6673a23365f05fe4d2ebdc793c135984d7b3410e59ef92fa75L33)) * Fix indentation of comment explaining trailing newline in rad.yaml template ([link](https://github.com/project-radius/radius/pull/5600/files?diff=unified&w=0#diff-1b0ac5c011aaaf6673a23365f05fe4d2ebdc793c135984d7b3410e59ef92fa75L46-R49)) (cherry picked from commit c715d39)
5 tasks
lakshmimsft
added a commit
that referenced
this pull request
May 26, 2023
# Description Cherry Picking #5600 into v0.21 release ## Checklist Please make sure you've completed the relevant tasks for this PR, out of the following list: * [ ] Code compiles correctly * [ ] Adds necessary unit tests for change * [ ] Adds necessary E2E tests for change * [ ] Unit tests passing * [ ] Extended the documentation / Created issue for it ## Auto-generated summary <!-- GitHub Copilot for docs will auto-generate a summary of the PR --> <!-- copilot:all --> ### <samp>🤖 Generated by Copilot at 50aa7d5</samp> ### Summary 📝🐛🧪 <!-- 1. 📝 - This emoji represents documentation, which is one of the aspects that was updated in the workflow. 2. 🐛 - This emoji represents bug fixes, which is another aspect that was addressed in the workflow by removing the location field and fixing the newline issue. 3. 🧪 - This emoji represents testing, which is the third aspect that was improved in the workflow by aligning the validation tool with the radius CLI tool. --> Update workflow and templates to match radius CLI release/0.21. This improves the project's documentation, validation, and configuration. > _To keep the project in sync_ > _They updated the docs and the `rad` link_ > _They removed location_ > _And fixed newline creation_ > _In the setup package templates with a wink_ ### Walkthrough * Align documentation and sample code with release candidate version of radius CLI tool ([link](https://github.com/project-radius/radius/pull/5604/files?diff=unified&w=0#diff-4f41a75886a1a479805bae1b7fb335479735aa7740e02b9e5c19992ead18f73eL40-R40), [link](https://github.com/project-radius/radius/pull/5604/files?diff=unified&w=0#diff-4f41a75886a1a479805bae1b7fb335479735aa7740e02b9e5c19992ead18f73eL47-R47), [link](https://github.com/project-radius/radius/pull/5604/files?diff=unified&w=0#diff-4f41a75886a1a479805bae1b7fb335479735aa7740e02b9e5c19992ead18f73eL60-R60)) * Remove location field from application.yaml template in setup package ([link](https://github.com/project-radius/radius/pull/5604/files?diff=unified&w=0#diff-1b0ac5c011aaaf6673a23365f05fe4d2ebdc793c135984d7b3410e59ef92fa75L30)) * Remove trailing newline in rad.yaml template in setup package ([link](https://github.com/project-radius/radius/pull/5604/files?diff=unified&w=0#diff-1b0ac5c011aaaf6673a23365f05fe4d2ebdc793c135984d7b3410e59ef92fa75L43-R46)) --------- Co-authored-by: Yetkin Timocin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing location from scaffolded application.
app.bicephas location but docs don't show location in theapp.bicep.Issue reference
Fixes: #5601
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
Auto-generated summary
🤖 Generated by Copilot at ea6ec87
Summary
🗑️🛠️📝
Simplified and improved
radCLI setup command by removing unused field and fixing comment indentation in config templates.Walkthrough