Tests fail on Windows when Repo setup in Windows filesystem before starting Devcontainer.

[jhandel]

Steps to reproduce

Pull source code from GH client in Windows cmd (or GH desktop).
Start Devcontainer using VS Code Devcontainer extension
Run make build
Run make test

tests that rely on comparing sample files (like terraform recipe tests) fail due to test files being checked out with LFCR (\r\n) but tests expecting only LF (\n)

Observed behavior

Example results from terraform test.

expected  : &terraform.moduleInspectResult{ContextVarExists:true, RequiredProviders:[]string{"aws"}, ResultOutputExists:true, Parameters:map[string]interface {}{"context":map[string]interface {}{"defaultValue":interface {}(nil), "description":"This variable contains Radius recipe context.", "name":"context", "pos":tfconfig.SourcePos{Filename:"testdata/.terraform/modules/test-module-recipe-context-outputs/variables.tf", Line:1}, "required":true, "sensitive":false, "type":"object({\n    resource = object({\n      name = string\n      id = string\n      type = string\n    })\n\n    application = object({\n      name = string\n      id = string\n    })\n\n    environment = object({\n      name = string\n      id = string\n    })\n\n    runtime = object({\n      kubernetes = optional(object({\n        namespace = string\n        environmentNamespace = string\n      }))\n    })\n\n    azure = optional(object({\n      resourceGroup = object({\n        name = string\n        id = string\n      })\n      subscription = object({\n        subscriptionId = string\n        id = string\n      })\n    }))\n    \n    aws = optional(object({\n      region = string\n      account = string\n    }))\n  })"}}}
actual  : &terraform.moduleInspectResult{ContextVarExists:true, RequiredProviders:[]string{"aws"}, ResultOutputExists:true, Parameters:map[string]interface {}{"context":map[string]interface {}{"defaultValue":interface {}(nil), "description":"This variable contains Radius recipe context.", "name":"context", "pos":tfconfig.SourcePos{Filename:"testdata/.terraform/modules/test-module-recipe-context-outputs/variables.tf", Line:1}, "required":true, "sensitive":false, "type":"object({\r\n    resource = object({\r\n      name = string\r\n      id = string\r\n      type = string\r\n    })\r\n\r\n    application = object({\r\n      name = string\r\n      id = string\r\n    })\r\n\r\n    environment = object({\r\n      name = string\r\n      id = string\r\n    })\r\n\r\n    runtime = object({\r\n      kubernetes = optional(object({\r\n        namespace = string\r\n        environmentNamespace = string\r\n      }))\r\n    })\r\n\r\n    azure = optional(object({\r\n      resourceGroup = object({\r\n        name = string\r\n        id = string\r\n      })\r\n      subscription = object({\r\n        subscriptionId = string\r\n        id = string\r\n      })\r\n    }))\r\n    \r\n    aws = optional(object({\r\n      region = string\r\n      account = string\r\n    }))\r\n  })"}}}

Desired behavior

working tests pass.

Workaround

add .gitattributes

*.tf text eol=lf
*.json text eol=lf
*.yaml text eol=lf

to the following folders:

• pkg/corperp/renderers/containers/testdata
• pkg/recipes/terraform/config/testdata
• pkg/recipes/terraform/testdata/.terraform/modules

rad Version

v0.30.0-rc3-2-g2e4d2ed

Operating system

Windows 11 with WSL 2 and Docker Desktop running the Devcontainer from the solution.

Additional context

No response

Would you like to support us?

• Yes, I would like to support you

AB#11104

[radius-triage-bot]

👋 @jhandel Thanks for filing this bug report.

A project maintainer will review this report and get back to you soon. If you'd like immediate help troubleshooting, please visit our Discord server.

For more information on our triage process please visit our triage overview

[radius-triage-bot]

👍 We've reviewed this issue and have agreed to add it to our backlog. Please subscribe to this issue for notifications, we'll provide updates when we pick it up.

We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

For more information on our triage process please visit our triage overview

[nicolejms]

There is open PR associated with this so may be fixed once merged.