Update RequireResource to handle duplicate short names and proper fully qualified names (also make life a little better for windows file system contributors) #7134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s the same linefeed as the test expects Signed-off-by: Josh <[email protected]>
…ification if duplicates are found Signed-off-by: Josh <[email protected]>
vinayada1
reviewed
Feb 5, 2024
|
@jhandel - Thanks for your contribution. |
jhandel
changed the title
Added new clivalidation_test.go with a test for RequireResrouceType Also Updated delete_test, list_test, and show_test in cli/resources so that the arguments tests for those commands would include testing for ambigous types Signed-off-by: Josh <[email protected]>
jhandel
temporarily deployed
to
functional-tests
GitHub Actions
Inactive
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
jhandel
temporarily deployed
to
functional-tests
GitHub Actions
Inactive
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
lakshmimsft
approved these changes
Feb 8, 2024
willdavsmith
pushed a commit
to willdavsmith/radius
that referenced
this pull request
Mar 4, 2024
…ly qualified names (also make life a little better for windows file system contributors) (radius-project#7134) # Description Updated clivalidation.RequireResourceType so that it can take either fully qualified names or short names.. and if a short name is used and there are duplicate short names display the list of matching short names. I also added a .gitattributes to the following folders so that their test files would maintain lf line ends instead of crlf line ends when cloned or pulled into a windows filesystem. * pkg/corperp/renderers/containers/testdata * pkg/recipes/terraform/config/testdata * pkg/recipes/terraform/testdata/.terraform/modules ## Type of change This pull request fixes a bug in Radius and has an approved issue Fixes: radius-project#7070 This pull request fixes a bug in Radius but its not an approved issue Fixes: radius-project#7121 --------- Signed-off-by: Josh <[email protected]>
willdavsmith
pushed a commit
to willdavsmith/radius
that referenced
this pull request
Apr 8, 2024
…ly qualified names (also make life a little better for windows file system contributors) (radius-project#7134) # Description Updated clivalidation.RequireResourceType so that it can take either fully qualified names or short names.. and if a short name is used and there are duplicate short names display the list of matching short names. I also added a .gitattributes to the following folders so that their test files would maintain lf line ends instead of crlf line ends when cloned or pulled into a windows filesystem. * pkg/corperp/renderers/containers/testdata * pkg/recipes/terraform/config/testdata * pkg/recipes/terraform/testdata/.terraform/modules ## Type of change This pull request fixes a bug in Radius and has an approved issue Fixes: radius-project#7070 This pull request fixes a bug in Radius but its not an approved issue Fixes: radius-project#7121 --------- Signed-off-by: Josh <[email protected]> Signed-off-by: willdavsmith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated clivalidation.RequireResourceType so that it can take either fully qualified names or short names.. and if a short name is used and there are duplicate short names display the list of matching short names.
I also added a .gitattributes to the following folders so that their test files would maintain lf line ends instead of crlf line ends when cloned or pulled into a windows filesystem.
Type of change
This pull request fixes a bug in Radius and has an approved issue
Fixes: #7070
This pull request fixes a bug in Radius but its not an approved issue
Fixes: #7121