Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI Tests excluded from functional tests workflow #7279

Closed
1 task
kachawla opened this issue Mar 6, 2024 · 1 comment · Fixed by #7286
Closed
1 task

CLI Tests excluded from functional tests workflow #7279

kachawla opened this issue Mar 6, 2024 · 1 comment · Fixed by #7286
Assignees
Labels
bug Something is broken or not working as expected

Comments

@kachawla
Copy link
Contributor

kachawla commented Mar 6, 2024

Steps to reproduce

This commit 0c2406b moved CLI tests out of the shared folder, resulting into them being skipped from functional test runs.

Observed behavior

CLI tests aren't executing as a part of functional test run workflow, for example: https://github.com/radius-project/radius/actions/runs/8166973316/job/22326708720

Desired behavior

All functional tests should be included in the functional test workflow.

Workaround

Rely on long running workflow failure reporting, since make target for long running workflow is different, explicitly targeting all https://github.com/radius-project/radius/blob/main/.github/workflows/long-running-azure.yaml#L440

rad Version

N/A

Operating system

N/A

Additional context

No response

Would you like to support us?

  • Yes, I would like to support you

AB#11403

@kachawla kachawla added the bug Something is broken or not working as expected label Mar 6, 2024
@radius-triage-bot
Copy link

👋 @kachawla Thanks for filing this bug report.

A project maintainer will review this report and get back to you soon. If you'd like immediate help troubleshooting, please visit our Discord server.

For more information on our triage process please visit our triage overview

vinayada1 added a commit that referenced this issue Mar 6, 2024
# Description

cli tests were moved out of the shared folder. The functional test
workflow was missing the cli tests in the matrix and it does not use
"make test-functional-all" unlike the long running tests. As a result,
these tests were skipped. This PR adds the cli tests to the matrix.

## Type of change

<!--

Please select **one** of the following options that describes your
change and delete the others. Clearly identifying the type of change you
are making will help us review your PR faster, and is used in authoring
release notes.

If you are making a bug fix or functionality change to Radius and do not
have an associated issue link please create one now.

-->

- This pull request fixes a bug in Radius and has an approved issue
(#7279 ).


<!--

Please update the following to link the associated issue. This is
required for some kinds of changes (see above).

-->

Fixes: #7279

Signed-off-by: vinayada1 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken or not working as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants