MBCP - updates to container,env,app datamodel #4448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytimocin
reviewed
Nov 2, 2022
ytimocin
reviewed
Nov 2, 2022
...pplications/resource-manager/Applications.Core/preview/2022-03-15-privatepreview/global.json
Outdated
Show resolved
Hide resolved
...cations/resource-manager/Applications.Core/preview/2022-03-15-privatepreview/containers.json
Outdated
Show resolved
Hide resolved
|
Merging with updated datamodel..converting temporarily back to draft |
lakshmimsft
force-pushed
the
ljavadekar/mbcpdatamodelupd
branch
from
b3981c1 to
d52c1e5
Compare
rynowak
reviewed
Nov 3, 2022
pkg/corerp/api/v20220315privatepreview/testdata/containerresourcedatamodel.json
Outdated
Show resolved
Hide resolved
rynowak
reviewed
Nov 3, 2022
pkg/corerp/api/v20220315privatepreview/testdata/containerresourcedatamodel.json
Outdated
Show resolved
Hide resolved
rynowak
reviewed
Nov 3, 2022
5 tasks
jkotalik
force-pushed
the
ljavadekar/mbcpdatamodelupd
branch
from
a5b5470 to
7e23388
Compare
lakshmimsft
changed the title
lakshmimsft
force-pushed
the
ljavadekar/mbcpdatamodelupd
branch
from
39715b1 to
7115bfc
Compare
jkotalik
reviewed
Nov 7, 2022
pkg/corerp/api/v20220315privatepreview/application_conversion.go
Outdated
Show resolved
Hide resolved
jkotalik
reviewed
Nov 7, 2022
pkg/corerp/api/v20220315privatepreview/application_conversion_test.go
Outdated
Show resolved
Hide resolved
jkotalik
reviewed
Nov 7, 2022
pkg/corerp/api/v20220315privatepreview/container_conversion_test.go
Outdated
Show resolved
Hide resolved
jkotalik
reviewed
Nov 7, 2022
pkg/corerp/api/v20220315privatepreview/container_conversion_test.go
Outdated
Show resolved
Hide resolved
jkotalik
reviewed
Nov 7, 2022
pkg/corerp/api/v20220315privatepreview/environment_conversion_test.go
Outdated
Show resolved
Hide resolved
jkotalik
reviewed
Nov 7, 2022
pkg/corerp/api/v20220315privatepreview/testdata/containerresourcedatamodel.json
Outdated
Show resolved
Hide resolved
jkotalik
reviewed
Nov 7, 2022
pkg/corerp/api/v20220315privatepreview/testdata/environmentresource.json
Outdated
Show resolved
Hide resolved
jkotalik
reviewed
Nov 7, 2022
jkotalik
reviewed
Nov 7, 2022
| @@ -1,389 +1,388 @@ | |||
| { | |||
| "swagger": "2.0", | |||
There was a problem hiding this comment.
The diff in this file shouldn't be this large, can you reformat it with the same format as before?
There was a problem hiding this comment.
got file from main branch and re-applied changes. still no joy.
There was a problem hiding this comment.
Try reformatting with 4 spaces for tabs instead of 2? Probably vscode auto formatting on save if I had to guess.
There was a problem hiding this comment.
Actually scratch that, other files are formatted with 2 spaces below. Let me just check the diff that is actually different.
youngbupark
reviewed
Nov 7, 2022
...cations/resource-manager/Applications.Core/preview/2022-03-15-privatepreview/containers.json
Show resolved
Hide resolved
vinayada1
reviewed
Nov 9, 2022
lakshmimsft
force-pushed
the
ljavadekar/mbcpdatamodelupd
branch
from
19b38f6 to
eddcd18
Compare
jkotalik
reviewed
Nov 15, 2022
pkg/corerp/api/v20220315privatepreview/container_conversion_test.go
Outdated
Show resolved
Hide resolved
jkotalik
reviewed
Nov 15, 2022
jkotalik
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to container,application,environment datamodel to account for KubernetesMetadataExtension
Note: some overlap with PR https://github.com/project-radius/radius/pull/4443/files
which we have now resolved
#4442
Fixes: #4442
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: