Updating datamodel to use ContainerExtension types #4469
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rynowak
approved these changes
Nov 4, 2022
There was a problem hiding this comment.
LGTM - would be good to get a signoff from @ytimocin or @youngbupark as well.
jkotalik
force-pushed
the
jkotalik/dataModelUpdate
branch
from
206a15c to
a91d2ea
Compare
|
Closing as #4448 will have these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes datamodel for Container/Application/Enviornment for Extensions. Forgot to add the right type as the array type.
Again the place we are starting from is that Application Extensions are separate from Environment extensions, etc. We are assuming that it is a bad user experience to be able to specify the DaprExtension at the application layer that noops or throws at deploy time rather than at compile time.
Issue reference
Part of #4442, #4448 will finish the fight
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: