Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Stop build if coverage is lower than main" #5473

Merged
merged 3 commits into from
Apr 24, 2023
Merged

Revert "Stop build if coverage is lower than main" #5473

merged 3 commits into from
Apr 24, 2023

Conversation

sylvainsf
Copy link
Contributor

Reverts enforcement of coverage blocker on builds per discussion with @nicolejms

@sylvainsf sylvainsf requested a review from a team as a code owner April 21, 2023 18:10
rynowak
rynowak reviewed Apr 21, 2023
View reviewed changes
.github/workflows/build.yaml

> The coverage result does not include the functional test coverage.
- name: Stop build if PR branch coverage is lower than main branch.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link

61.1

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 61.1 %
  • main branch coverage: 61.1 %

The coverage result does not include the functional test coverage.

@nicolejms
Copy link
Contributor

Thanks for the quick turnaround

@shalabhms shalabhms self-requested a review April 21, 2023 18:46
@github-actions
Copy link

61.5

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 61.5 %
  • main branch coverage: 61.5 %
  • diff coverage: %

The coverage result does not include the functional test coverage.

youngbupark
youngbupark reviewed Apr 22, 2023
View reviewed changes
.github/workflows/build.yaml Outdated
Comment on lines 116 to 118
DIFF_RATE=$(echo "$UT_COVERAGE-$MAIN_COVERAGE" | bc -l)
echo "diff_coverage=$DIFF_RATE" >> $GITHUB_ENV

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs to be reverted back.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is what sets env.diff_coverage

@sylvainsf
Update build.yaml
bde0f3f 
adding diff rate back to report
@github-actions
Copy link

61.5

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 61.5 %
  • main branch coverage: 61.5 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

@sylvainsf sylvainsf merged commit 7df35f4 into main Apr 24, 2023
@sylvainsf sylvainsf deleted the revert-5300-youngp/stop-build-cov branch April 24, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kachawla kachawla kachawla approved these changes

@willdavsmith willdavsmith willdavsmith approved these changes

@shalabhms shalabhms shalabhms approved these changes

@youngbupark youngbupark youngbupark approved these changes

@ytimocin ytimocin ytimocin approved these changes

@rynowak rynowak rynowak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@sylvainsf @nicolejms @rynowak @ytimocin @youngbupark @shalabhms @willdavsmith @kachawla