Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Stop build if coverage is lower than main" #5473

Merged
merged 3 commits into from
Apr 24, 2023
Merged

Revert "Stop build if coverage is lower than main" #5473

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
019d614
Revert "Stop build if coverage is lower than main (#5300)"
sylvainsf Apr 21, 2023
3efdc9b
adding diff back in
sylvainsf Apr 22, 2023
bde0f3f
Update build.yaml
sylvainsf Apr 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,9 +113,6 @@ jobs:
COLOR=green
fi

DIFF_RATE=$(echo "$UT_COVERAGE-$MAIN_COVERAGE" | bc -l)
echo "diff_coverage=$DIFF_RATE" >> $GITHUB_ENV

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs to be reverted back.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is what sets env.diff_coverage

echo "coverage_img=https://img.shields.io/badge/coverage-$UT_COVERAGE%25-$COLOR" >> $GITHUB_ENV
# copy coverage to cache
cp ./dist/ut_coverage.txt ./dist/cache/
Expand Down Expand Up @@ -151,14 +148,8 @@ jobs:

* Your PR branch coverage: ${{ env.ut_coverage }} %
* main branch coverage: ${{ env.main_coverage }} %
* diff coverage: ${{ env.diff_coverage }} %
AaronCrawfis marked this conversation as resolved.
Show resolved Hide resolved

> The coverage result does not include the functional test coverage.
- name: Stop build if PR branch coverage is lower than main branch.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

if: (env.main_coverage > env.ut_coverage) && matrix.target_arch == 'amd64' && matrix.target_os == 'linux' && github.event.pull_request
run: |
echo "stop build to prevent from merging PR because coverage is down from ${{ env.main_coverage }} % to ${{ env.ut_coverage }} %."
exit 1
- name: Save coverage (only main push)
uses: actions/cache/save@v3
if: matrix.target_arch == 'amd64' && matrix.target_os == 'linux' && github.ref == 'refs/heads/main'
Expand Down