Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make label validation optional for recipe functional tests #5530

Merged
merged 7 commits into from
May 11, 2023
Merged

Make label validation optional for recipe functional tests #5530

merged 7 commits into from
May 11, 2023

Conversation

vishwahiremat
Copy link
Contributor

@vishwahiremat vishwahiremat commented May 5, 2023 •
edited by shalabhms
Loading

Description

Core RP adds "radius.dev/application", "radius.dev/resource" labels on Radius containers. These labels aren't required in customer recipes but test framework pod validation currently expects these to present.

  • Added SkipLabelsValidation flag to the test step, using that we can disable labels validation.

Issue reference

#5095

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Adds necessary unit tests for change
  • Adds necessary E2E tests for change
  • Unit tests passing
  • Extended the documentation / Created issue for it

@github-actions
Copy link

github-actions bot commented May 5, 2023 •
edited
Loading

Test Results

2 528 tests  ±0   2 521 ✔️ ±0   2m 0s ⏱️ +3s
   230 suites ±0          7 💤 ±0 
       1 files   ±0          0 ❌ ±0 

Results for commit 1681ece. ± Comparison against base commit 70939e0.

This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both. 
github.com/project-radius/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/1ec4885a-9be9-434c-bc7f-676ff599a45c
github.com/project-radius/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/1ec4885a-9be9-434c-bc7f-676ff599a45c#01

github.com/project-radius/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/afffdbae-dc71-41ff-be50-cda650dd6f85
github.com/project-radius/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/afffdbae-dc71-41ff-be50-cda650dd6f85#01

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 5, 2023

62.1

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 62.1 %
  • main branch coverage: 62.1 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

@vishwahiremat vishwahiremat marked this pull request as ready for review May 8, 2023 06:41
@vishwahiremat vishwahiremat requested a review from a team as a code owner May 8, 2023 06:41
@github-actions
Copy link

github-actions bot commented May 8, 2023

62.1

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 62.1 %
  • main branch coverage: 62.1 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

shalabhms
shalabhms reviewed May 8, 2023
View reviewed changes
test/validation/k8s.go Outdated Show resolved Hide resolved
@shalabhms
Copy link
Contributor

@vishwahiremat - could you please update the #issue_number?

@github-actions
Copy link

github-actions bot commented May 8, 2023

62.2

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 62.2 %
  • main branch coverage: 62.2 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

1 similar comment
@github-actions
Copy link

github-actions bot commented May 8, 2023

62.2

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 62.2 %
  • main branch coverage: 62.2 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

@shalabhms shalabhms self-requested a review May 8, 2023 20:56
shalabhms
shalabhms approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@shalabhms shalabhms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for resolving comments. /lgtm.

@github-actions
Copy link

github-actions bot commented May 8, 2023

62.2

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 62.2 %
  • main branch coverage: 62.2 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

rynowak
rynowak reviewed May 8, 2023
View reviewed changes
test/functional/corerp/resources/mongodb_test.go Outdated
},
},
},
SkipLabelValidation: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of skipping validation for whole steps, what if we skipped it for individual pods? That seems like a better fit for the scenario.

For example in this test we'd still validate the application container, but not the pod created by the recipe.

@github-actions
Copy link

github-actions bot commented May 10, 2023 •
edited
Loading

Radius functional test overview

🔍 Go to test action run

Name Value
Repository project-radius/radius
Commit ref b9788dc
Unique ID d248584b60
Image tag pr-d248584b60
Click here to see the list of tools in the current test run
  • KinD: v0.18.0
  • Dapr: 1.10.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.0.0
  • recipe location radiusdev.azurecr.io/test/functional/corerp/recipes/<name>:pr-d248584b60
  • appcore-rp test image location: radiusdev.azurecr.io/appcore-rp:pr-d248584b60
  • ucp test image location: radiusdev.azurecr.io/ucpd:pr-d248584b60

Test Status

✅ Building Radius and pushing container images for functional test...
✅ Test image build succeeded
❌ Test recipe publishing failed

@github-actions
Copy link

github-actions bot commented May 10, 2023 •
edited
Loading

Radius functional test overview

🔍 Go to test action run

Name Value
Repository project-radius/radius
Commit ref 0e149c0
Unique ID 0cb10e445e
Image tag pr-0cb10e445e
Click here to see the list of tools in the current test run
  • KinD: v0.18.0
  • Dapr: 1.10.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.0.0
  • recipe location radiusdev.azurecr.io/test/functional/corerp/recipes/<name>:pr-0cb10e445e
  • appcore-rp test image location: radiusdev.azurecr.io/appcore-rp:pr-0cb10e445e
  • ucp test image location: radiusdev.azurecr.io/ucpd:pr-0cb10e445e

Test Status

✅ Building Radius and pushing container images for functional test...
✅ Test image build succeeded
✅ Test recipe publishing succeeded
✅ Starting ucp functional tests...
✅ Starting samples functional tests...
✅ Starting corerp functional tests...
🚀 samples functional tests passed.
🚀 ucp functional tests passed.
🚀 corerp functional tests passed.

@github-actions
Copy link

github-actions bot commented May 10, 2023 •
edited
Loading

Radius functional test overview

🔍 Go to test action run

Name Value
Repository project-radius/radius
Commit ref 1681ece
Unique ID 814c8405b9
Image tag pr-814c8405b9
Click here to see the list of tools in the current test run
  • KinD: v0.18.0
  • Dapr: 1.10.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.0.0
  • recipe location radiusdev.azurecr.io/test/functional/corerp/recipes/<name>:pr-814c8405b9
  • appcore-rp test image location: radiusdev.azurecr.io/appcore-rp:pr-814c8405b9
  • ucp test image location: radiusdev.azurecr.io/ucpd:pr-814c8405b9

Test Status

✅ Building Radius and pushing container images for functional test...
✅ Test image build succeeded
✅ Test recipe publishing succeeded
✅ Starting ucp functional tests...
✅ Starting corerp functional tests...
✅ Starting samples functional tests...
🚀 samples functional tests passed.
🚀 ucp functional tests passed.
🚀 corerp functional tests passed.

@github-actions
Copy link

62.4

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 62.4 %
  • main branch coverage: 62.4 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

@vishwahiremat vishwahiremat merged commit d1e2d4a into main May 11, 2023
@vishwahiremat vishwahiremat deleted the vishwahiremat/skip_label_validation branch May 11, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rynowak rynowak rynowak left review comments

@shalabhms shalabhms shalabhms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vishwahiremat @shalabhms @rynowak