Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipes Test framework improvements #5095

Closed
jasonviviano opened this issue Feb 1, 2023 · 1 comment
Closed

Recipes Test framework improvements #5095

jasonviviano opened this issue Feb 1, 2023 · 1 comment
Labels
triaged This issue has been reviewed and triaged

Comments

@jasonviviano
Copy link
Contributor

jasonviviano commented Feb 1, 2023

Epic for all test framework improvements needed for Recipes before public release.

AB#5955

@kachawla kachawla removed their assignment Feb 22, 2023
@AaronCrawfis AaronCrawfis added the triaged This issue has been reviewed and triaged label Mar 27, 2023
@shalabhms shalabhms changed the title Test framework improvements [Tech Debt] Test framework improvements in Recipe Mar 30, 2023
@kachawla
Copy link
Contributor

Parent scenario is already "tech debt" https://dev.azure.com/azure-octo/Incubations/_workitems/edit/5081, the title is repetitive.

@kachawla kachawla changed the title [Tech Debt] Test framework improvements in Recipe Recipes Test framework improvements Mar 31, 2023
vishwahiremat added a commit that referenced this issue May 11, 2023
# Description

Core RP adds "radius.dev/application", "radius.dev/resource" labels on
Radius containers. These labels aren't required in customer recipes but
test framework pod validation currently expects these to present.

- Added SkipLabelsValidation flag to the test step, using that we can
disable labels validation.

## Issue reference

<!--
We strive to have all PR being opened based on an issue, where the
problem or feature have been discussed prior to implementation.
-->

#5095
## Checklist

Please make sure you've completed the relevant tasks for this PR, out of
the following list:

* [x] Code compiles correctly
* [ ] Adds necessary unit tests for change
* [ ] Adds necessary E2E tests for change
* [ ] Unit tests passing
* [x] Extended the documentation / Created issue for it
vishwahiremat added a commit that referenced this issue May 15, 2023
# Description

Updated the recipe template path on functional test bicep files to use
the registery and version environment vairables.

## Issue reference

<!--
We strive to have all PR being opened based on an issue, where the
problem or feature have been discussed prior to implementation.
-->

#5095

## Checklist

Please make sure you've completed the relevant tasks for this PR, out of
the following list:

* [x] Code compiles correctly
* [ ] Adds necessary unit tests for change
* [x] Adds necessary E2E tests for change
* [x] Unit tests passing
* [ ] Extended the documentation / Created issue for it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged This issue has been reviewed and triaged
Projects
None yet
Development

No branches or pull requests

3 participants