New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

possible memory leak with sessions #25

Closed

LeSpocky opened this issue May 10, 2016 · 2 comments · Fixed by #44

Assignees

Labels

api bug has pull request

Milestone

Collaborator

LeSpocky commented May 10, 2016

The global variable sess_fname is a pointer to dynamically allocated memory which happens either in sess_generate_id() or in cgi_session_start(). However this memory is never freed.

The text was updated successfully, but these errors were encountered:

LeSpocky added the bug label

LeSpocky added this to the v1.1 milestone

LeSpocky self-assigned this

Collaborator Author

LeSpocky commented May 11, 2016

This is not easy to solve. sess_fname is currently a static variable in session.c and the only API function exposed in the headers which could do this is cgi_end() which is implemented in cgi.c.

Exposing the variable globally: bad. Exposing the variable to cgi.c only: not possible without exposing it globally (?).

This whole concept of global variables in a library is broken, but for v1.x we can't change it anymore, if we want to maintain API compatibility.

I propose adding a new function like cgi_session_free() which does the cleanup.

LeSpocky modified the milestones: v1.1.1, v1.1

LeSpocky modified the milestones: v1.2, v1.1.1

Collaborator Author

LeSpocky commented Feb 16, 2017

Moved this to milestone v1.2, because introducing a new function would extend the API which would trigger a minor version bump with semantic versioning.

LeSpocky added the api label

LeSpocky added a commit to LeSpocky/libcgi that referenced this issue


          Added API function to free session internals

228d555

This fixes a possible memory leak when working with sessions (especially
with some non-mainline fcgi patches). Quoting from the ticket:

The global variable `sess_fname` is a pointer to dynamically allocated
memory which happens either in `sess_generate_id()` or in
`cgi_session_start()`. However this memory is never freed.

To not expose the variable globally or even just to `cgi.c` where e.g.
`cgi_end()` could access it, a new API function is introduced. We leave
bumping the API version up to a follow up commit.

fixes rafaelsteil#25

Signed-off-by: Alexander Dahl <[email protected]>

LeSpocky added a commit to LeSpocky/libcgi that referenced this issue


          Introduce tests for session

f60ab07

This is a follow-up to rafaelsteil#25 to ensure this all works like it should
without evil memory leaks, null pointer dereferences, …

Now the first test here is very simple, just to get this test module
running.

Signed-off-by: Alexander Dahl <[email protected]>

LeSpocky mentioned this issue

sess_initialized is never reset #33

Closed

LeSpocky added a commit to LeSpocky/libcgi that referenced this issue


          session: Added API function to free session internals

8b793ef

This fixes a possible memory leak when working with sessions (especially
with some non-mainline fcgi patches). Quoting from the ticket:

The global variable `sess_fname` is a pointer to dynamically allocated
memory which happens either in `sess_generate_id()` or in
`cgi_session_start()`. However this memory is never freed.

To not expose the variable globally or even just to `cgi.c` where e.g.
`cgi_end()` could access it, a new API function is introduced. We leave
bumping the API version up to a follow up commit.

fixes rafaelsteil#25

Signed-off-by: Alexander Dahl <[email protected]>

LeSpocky added a commit to LeSpocky/libcgi that referenced this issue


          Introduce tests for session

9a23e48

This is a follow-up to rafaelsteil#25 to ensure this all works like it should
without evil memory leaks, null pointer dereferences, …

Now the first test here is very simple, just to get this test module
running.

Signed-off-by: Alexander Dahl <[email protected]>

LeSpocky added a commit to LeSpocky/libcgi that referenced this issue


          Introduce tests for session

97cbe52

This is a follow-up to rafaelsteil#25 to ensure this all works like it should
without evil memory leaks, null pointer dereferences, …

Now the first test here is very simple, just to get this test module
running.

Signed-off-by: Alexander Dahl <[email protected]>

LeSpocky added a commit to LeSpocky/libcgi that referenced this issue


          session: Added API function to free session internals

163a31f

This fixes a possible memory leak when working with sessions (especially
with some non-mainline fcgi patches). Quoting from the ticket:

The global variable `sess_fname` is a pointer to dynamically allocated
memory which happens either in `sess_generate_id()` or in
`cgi_session_start()`. However this memory is never freed.

To not expose the variable globally or even just to `cgi.c` where e.g.
`cgi_end()` could access it, a new API function is introduced. We leave
bumping the API version up to a follow up commit.

fixes rafaelsteil#25

Signed-off-by: Alexander Dahl <[email protected]>

LeSpocky added a commit to LeSpocky/libcgi that referenced this issue


          Introduce tests for session

bb8a4d8

This is a follow-up to rafaelsteil#25 to ensure this all works like it should
without evil memory leaks, null pointer dereferences, …

Now the first test here is very simple, just to get this test module
running.

Signed-off-by: Alexander Dahl <[email protected]>

LeSpocky added a commit to LeSpocky/libcgi that referenced this issue


          session: Added API function to free session internals

49d7340

This fixes a possible memory leak when working with sessions (especially
with some non-mainline fcgi patches). Quoting from the ticket:

The global variable `sess_fname` is a pointer to dynamically allocated
memory which happens either in `sess_generate_id()` or in
`cgi_session_start()`. However this memory is never freed.

To not expose the variable globally or even just to `cgi.c` where e.g.
`cgi_end()` could access it, a new API function is introduced. We leave
bumping the API version up to a follow up commit.

fixes rafaelsteil#25

Signed-off-by: Alexander Dahl <[email protected]>

LeSpocky added a commit to LeSpocky/libcgi that referenced this issue


          Introduce tests for session

2390aee

This is a follow-up to rafaelsteil#25 to ensure this all works like it should
without evil memory leaks, null pointer dereferences, …

Now the first test here is very simple, just to get this test module
running.

Signed-off-by: Alexander Dahl <[email protected]>

LeSpocky added a commit to LeSpocky/libcgi that referenced this issue


          session: Added API function to free session internals

1ca33a0

This fixes a possible memory leak when working with sessions (especially
with some non-mainline fcgi patches). Quoting from the ticket:

The global variable `sess_fname` is a pointer to dynamically allocated
memory which happens either in `sess_generate_id()` or in
`cgi_session_start()`. However this memory is never freed.

To not expose the variable globally or even just to `cgi.c` where e.g.
`cgi_end()` could access it, a new API function is introduced. We leave
bumping the API version up to a follow up commit.

fixes rafaelsteil#25

Signed-off-by: Alexander Dahl <[email protected]>

LeSpocky added a commit to LeSpocky/libcgi that referenced this issue


          Introduce tests for session

5d67511

This is a follow-up to rafaelsteil#25 to ensure this all works like it should
without evil memory leaks, null pointer dereferences, …

Now the first test here is very simple, just to get this test module
running.

Signed-off-by: Alexander Dahl <[email protected]>

LeSpocky mentioned this issue

Session fixes #44

Merged

LeSpocky added the has pull request label

LeSpocky added a commit to LeSpocky/libcgi that referenced this issue


          session: Added API function to free session internals

4589ded

This fixes a possible memory leak when working with sessions (especially
with some non-mainline fcgi patches). Quoting from the ticket:

The global variable `sess_fname` is a pointer to dynamically allocated
memory which happens either in `sess_generate_id()` or in
`cgi_session_start()`. However this memory is never freed.

To not expose the variable globally or even just to `cgi.c` where e.g.
`cgi_end()` could access it, a new API function is introduced. We leave
bumping the API version up to a follow up commit.

fixes rafaelsteil#25

Signed-off-by: Alexander Dahl <[email protected]>

LeSpocky added a commit to LeSpocky/libcgi that referenced this issue


          Introduce tests for session

b3a3b3e

This is a follow-up to rafaelsteil#25 to ensure this all works like it should
without evil memory leaks, null pointer dereferences, …

Now the first test here is very simple, just to get this test module
running.

Signed-off-by: Alexander Dahl <[email protected]>

LeSpocky added a commit to LeSpocky/libcgi that referenced this issue


          session: Added API function to free session internals

9531f70

This fixes a possible memory leak when working with sessions (especially
with some non-mainline fcgi patches). Quoting from the ticket:

The global variable `sess_fname` is a pointer to dynamically allocated
memory which happens either in `sess_generate_id()` or in
`cgi_session_start()`. However this memory is never freed.

To not expose the variable globally or even just to `cgi.c` where e.g.
`cgi_end()` could access it, a new API function is introduced. We leave
bumping the API version up to a follow up commit.

Fixes: rafaelsteil#25
Signed-off-by: Alexander Dahl <[email protected]>

LeSpocky added a commit to LeSpocky/libcgi that referenced this issue


          test: Introduce tests for session

b59c3c4

This is a follow-up to rafaelsteil#25 to ensure this all works like it should
without evil memory leaks, null pointer dereferences, …

Now the first test here is very simple, just to get this test module
running.

Signed-off-by: Alexander Dahl <[email protected]>

LeSpocky closed this as completed in #44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment