Session fixes #44
Merged
Session fixes #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a possible memory leak when working with sessions (especially with some non-mainline fcgi patches). Quoting from the ticket: The global variable `sess_fname` is a pointer to dynamically allocated memory which happens either in `sess_generate_id()` or in `cgi_session_start()`. However this memory is never freed. To not expose the variable globally or even just to `cgi.c` where e.g. `cgi_end()` could access it, a new API function is introduced. We leave bumping the API version up to a follow up commit. Fixes: rafaelsteil#25 Signed-off-by: Alexander Dahl <[email protected]>
Signed-off-by: Alexander Dahl <[email protected]>
The flag `sess_initialized` was never reset. After introducing `cgi_session_free()` we can now reset it. While at it use `stdbool.h` and make the variable a proper boolean, and also drop the not really used `sess_finitialized` variable. Fixes: rafaelsteil#33 Signed-off-by: Alexander Dahl <[email protected]>
This is a follow-up to rafaelsteil#25 to ensure this all works like it should without evil memory leaks, null pointer dereferences, … Now the first test here is very simple, just to get this test module running. Signed-off-by: Alexander Dahl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are from a tested personal branch to fix #25 and #33, includes some new tests.