Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss process to merge PR to main HHS repo #186

Closed
4 tasks done
shubhi-raft opened this issue Aug 21, 2020 · 3 comments
Closed
4 tasks done

Discuss process to merge PR to main HHS repo #186

shubhi-raft opened this issue Aug 21, 2020 · 3 comments
Assignees

Comments

@shubhi-raft
Copy link
Collaborator

shubhi-raft commented Aug 21, 2020

Description:
Discuss and finalize the process to merge PR from Raft fork to the main HHS repo.

AC:

  • Process is finalized and documented.

Tasks:

  • Document who approves the PR and merges it into main HHS repo
  • Document the finalized process in wiki and team charter
  • Docker Layer Caching, Raft has it, HHS doesn't and seems to fail build? (speeds up builds, starting at $30/mo)
@shubhi-raft
Copy link
Collaborator Author

@lfrohlich this has been documented in the team charter.

@RafterGit
Copy link

Need to discuss PR review process and remediation follow up process with Alex and Laura as part of the roll-off process.

@SelenaJV SelenaJV assigned alexsoble and unassigned lauraGgit Oct 8, 2020
@alexsoble
Copy link

I think this one is all done!

Docker layer caching removed, all CircleCI builds on the HHS repo are green.

Documented review process to the docs folder here: https://github.com/HHS/TANF-app/blob/main/docs/PR%20Review/qasp-operational-checklist.md

carltonsmith pushed a commit that referenced this issue Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants