SPRINT 3 RELEASE #55
SPRINT 3 RELEASE #55
Conversation
They currently contain no sensitive data but if that changes, this sets things up so they're ignored. Any additions to .env.local or .env.test should be added to .env.example with dummy values. The readme provides instructions to set up the project with these files.
The command in the Readme (to run app locally) mounts the src directory making it possible for local development changes to be reflected in the container without restarting/rebeuilding it each time. A previous change moved the Dockerfiles into a subdirectory which broke this functionality. Additionally, with the Dockerfles in the subdirectory, the .dockerignore wasn't being picked up at build time. Also, at build time, with the files in a subdir, the context was incorrect. Certain commands referenced files in the same directory as the Dockerfile and this broke when the Dockerfile changed to a sub dir
To perform imports from relative paths and node_modules. docs: https://create-react-app.dev/docs/adding-a-sass-stylesheet Also, adjust the .env strategy as per the intended usage: facebook/create-react-app#6961 (comment) - anything ending with .local must not be tracked. - .test and .development should be tracked. Consequently, remove the README instructions for setting up .env since they're not necessary anymore.
To match the designs in figma. Use include-media to cleanly define breakpoints and reference in scss files. This sets up the patter going forward for all responsive implementation (mobile first)
For some reason snyk was being run with the Jest unit tests. This decouples the two, which aren't related
References for the behavior: - sass/node-sass#2162 - sass/node-sass#1527 - sass/node-sass#2165
Supposed to be in tdrs-frontend (and is already)
So local development can have whatever config it needs without being pushed up to git
Because SASS imports require this config.
Otherwise all imports would need to change to
relative paths, like ('../../node_modules/my_package')
Also, remove unnecessary node-sass rebuild step
- This reverts commit: 4d1b0ea
There was an issue where an error is thrown related to
node-sass not having the correct binding for the Docker container.
The rebuild change did not resolve the issue
Previously SASS_PATH was set in .env.development and was available to the 'localdev' Dockerfile stage. However environment variables do not persist across build stages, and SASS_PATH wasn't available to the 'build' Dockerfile stage, causing an error during `yarn build`. The variable has now been added to the `yarn build` script so it works both when build in Docker and without Docker. Additionally, remove the `npm rebuild node-sass` step since it is not necessary. - This reverts commit: 4d1b0ea
Since it runs later in the workflow already
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
…o 172-landing-pages
some cleanup is needed for paddings and removal of inline styles
did welcome work in dashboard and needed to switch it back
Updated the template based on @221
- adding more test cases to the set_profile endpoint test suite - made the logic around creating a user session in login.py DRYer
…ot-check-remediations
…ted out code in _global.scss, add login logo
…rdheader and change it's font, add box-shadow to resource cards
Deliverable 6: DocumentedDocumentation updates look in line with what was delivered. Though, I saw that Makedoc is no longer being built, do you think you’ll replace that? We will be replacing this, the Mackdocs integration in the docker-compose configuration was a temporary proof of concept while we worked towards a permanent documentation approach so we can serve it without needing someone to pull down and spin up a local instance of the application such as the items defined in story 265. |
Deliverable 5: DeployedBecause of updates made outside of the deadline, the CF cli cannot be installed and the latest version is not deployed. Please see the note above. This is caused by an external issue. The external issue with the Cloud Foundry CLI tool installation has since been resolved as reported here Cloud Foundry GPG Key Expired Issue Upon merging of the remediation PRs, the CI/CD pipeline will have no issue installing and using the |
Deliverable 2: Tested CodeCypress test updates could better reflect the updated functionality. Updates to our cypress integration testing will be fleshed out more, for example leveraging the Cypress OTP tool to facilitate the Login.gov authentication process. Details of this have been captured in the 09/15/2020 dev pairing session and in issue 231. For this PR we've expanded the current cypress test to capture items on the Landing Page which is part of the raft-tech frontend remediation PR here. |
…tion Backend Remediations in response to the Sprint 3 PR review
Frontend Spot check remediations
|
@iamjolly / @lfrohlich This sprint looks good from me. |
|
Thanks @lauraGgit. This is also good from my perspective, @lfrohlich. |
|
Thanks, all. This looks good from my perspective. |
|
Additional notes from teams: Page title accessibility concerns have been captured in #283 Testing of the HTTPcookie will be added as a task to #231 |
Overview
PR to merge the user stories that were completed in Sprint 3.
List of completed user stories
List of user stories moving to next sprint
User research artifacts delivered: