Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] As a dev, I want to discuss replacing trussworks/react-uswdsis #274

Closed
8 tasks
shubhi-raft opened this issue Sep 15, 2020 · 1 comment
Closed
8 tasks
Assignees
Labels

Comments

@shubhi-raft
Copy link
Collaborator

shubhi-raft commented Sep 15, 2020

Description:
Need to further discuss what are the implications of replacing trussworks
We are using trussworks/react-uswdsis, a frontend USWDS component library, based on gov recommendation. Customizing USWDS theme color and font tokens for #172 was challenging due to unclear and not up to date documentation. The suggestion to use customize USWDS theme color and font could not be followed because trussworks/react-uswdsis, overrides all direct USWDS changes. Similarly, it has been challenging to customize the footer component because we are not able to add our own classes to some of the elements.

Furthermore, in the next sprint, we will be adding combo box feature #229. This feature has not been completely developed in trussworks and there is an active issue that is currently being worked on.

Given that trussworks/react-uswdsis is in active development, we would like to discuss replacing it and instead directly using USWDS components.

Acceptance Criteria:
Create a list of functional outcomes that must be achieved to complete this issue

  • Outcome 1
  • Outcome 2
  • Outcome 3
  • Testing Checklist has been run and all tests pass

Tasks:
Create a list of granular, specific work items that must be completed to deliver the desired outcomes of this issue

  • Create a detailed issue for the replacement
  • Task 2
  • Task 3
  • Run Testing Checklist and confirm all tests pass

Notes:
Add additional useful information, such as related issues and functionality that isn't covered by this specific issue, and other considerations that will be helpful for anyone reading this

  • Note 1
  • Note 2
  • Note 3

Supporting Documentation:
Please include any relevant log snippets/files/screen shots

  • Doc 1
  • Doc 2

Open Questions:
Please include any questions or decisions that must be made before beginning work or to confidently call this issue complete

  • Open Question 1
  • Open Question 2
@shubhi-raft
Copy link
Collaborator Author

Per dev pairing session on 9/15, the team agreed that removing trussworks made sense going forward since some of the USWDS features are still in active production. trussworks may still be used as a reference when designing our own components moving forward.

Issue for removing trussworks has been created. #280.

@lfrohlich this can be closed. per our discussion, new issue for removal has been created.

riatzukiza pushed a commit that referenced this issue Jul 22, 2022
Documentation: JWT Key Rotation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants