Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend Spot check remediations #262

Merged
merged 26 commits into from
Sep 16, 2020
Merged

Conversation

hilvitzs
Copy link

@hilvitzs hilvitzs commented Sep 11, 2020

This pull request changes...

  • Make better use of utility classes and uswds components
  • Make "Skip to Main Content" first selectable element with keyboard tab
  • Update secondary nav links to links instead of buttons
  • revised cypress tests for landing page

[AC] This pull request is ready to merge when...

  • Tests have been updated (and all tests are passing)
  • Vulnerability Scan Test (Zap) has no high/critcial CVEs
  • Linting Tests (ESLint for UI and Flake8 for Python)
  • Unit Tests ( including a code coverage test report)
  • Accessibility Tests (Pa11y UI Only)
  • This code has been reviewed by someone other than the original author
  • The experience passes a basic manual accessibility audit (keyboard nav, screenreader, text scaling) OR an exemption is documented
  • The change has been documented
  • Associated OpenAPI documentation has been updated
  • Changelog is updated as appropriate

[DoD] This feature is done when...

  • Design has approved the experience
  • Product has approved the experience

@RafterGit RafterGit closed this Sep 11, 2020
@RafterGit RafterGit reopened this Sep 13, 2020
@RafterGit RafterGit closed this Sep 13, 2020
@RafterGit RafterGit reopened this Sep 14, 2020
@hilvitzs hilvitzs force-pushed the spot-check-remediations branch from 108ecfb to 9168ca2 Compare September 14, 2020 22:34
@hilvitzs
Copy link
Author

After discussions with @carltonsmith, @shubhi-raft, and @lauraGgit we are going to remove trussworks from our project. It is just not quite mature enough to be used currently. Here is the issue: #274.

@RafterGit RafterGit changed the title Spot check remediations Frontend Spot check remediations Sep 15, 2020
tdrs-frontend/src/theme/_global.scss Outdated Show resolved Hide resolved
…ted out code in _global.scss, add login logo
@hilvitzs hilvitzs force-pushed the spot-check-remediations branch from 61633bd to ad6d1be Compare September 15, 2020 20:33
Copy link

@lauraGgit lauraGgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deployed version currently has the logo in the footer, but the local version from this branch does not. Can you add in that code here and it will be good to go?

@hilvitzs
Copy link
Author

I'm not sure how the deployed was different than the branch but I just pushed with the ACF logo replacing the placeholder.

@RafterGit RafterGit merged commit 64e3331 into raft-tdp-main Sep 16, 2020
@hilvitzs hilvitzs deleted the spot-check-remediations branch December 8, 2020 00:34
riatzukiza pushed a commit that referenced this pull request Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants