Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a user who uses a screen reader, I want to know which page I am on. #283

Closed
5 tasks done
shubhi-raft opened this issue Sep 16, 2020 · 2 comments
Closed
5 tasks done
Assignees
Labels
Milestone

Comments

@shubhi-raft
Copy link
Collaborator

shubhi-raft commented Sep 16, 2020

Description:
Currently, the authenticated page for a new user has the same page title as the pre-login landing page. Each page should have unique and descriptive site title for screen reader. This issue will deliver updating h1 content prepended to the site name - “Request Access | TDP - TANF Data Portal ” for the authenticated new user profile page.

Acceptance Criteria:

  • Each pages site title starts with the h1 content of the page

Tasks:
Create a list of granular, specific work items that must be completed to deliver the desired outcomes of this issue

  • See if using useEffect will work for updating page titles
  • If it will not work then bring in react-helmet package
  • Ensure edit profile page title is Request Access - TDP - TANF Data Portal
  • Run Testing Checklist and confirm all tests pass

Supporting Documentation:

Note:

  • May be brought onto Sprint 6 if other frontend isssues have been completed.
@shubhi-raft shubhi-raft changed the title [Accessibility] Sprint 3 PR Feedback: Update h1 content for a new user profile page who has been authenticated As a user who uses a screen reader, I want to know which page I am on. Sep 16, 2020
@cmajel
Copy link

cmajel commented Oct 14, 2020

adding note from sprint planning's zoom chat from @rahearn

On my way out, I'll let you know that I just tested a change that used "useEffect" to update the page title. It definitely works

@carltonsmith carltonsmith assigned riatzukiza and unassigned hilvitzs Oct 20, 2020
@shubhi-raft shubhi-raft added this to the Sprint 6 milestone Oct 28, 2020
@lfrohlich
Copy link
Collaborator

This was merged in PR #94 in Sprint 9 on 12/7/20

carltonsmith pushed a commit that referenced this issue Dec 30, 2020
Header title match -- looks good, satisfies AC of #283
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants