-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch File Encoding Errors with Package #3414
Conversation
- update bom check
- Add error handling
- Add error handling
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3414 +/- ##
===========================================
- Coverage 91.38% 91.34% -0.04%
===========================================
Files 299 299
Lines 8614 8624 +10
Branches 640 641 +1
===========================================
+ Hits 7872 7878 +6
- Misses 622 626 +4
Partials 120 120
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
- Move min bytes to a const - console log error if encoding fails
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…2854-file-encoding-with-package
…raft-tech/TANF-app into 2854-file-encoding-with-package
…esult to get the correct encoding
Closing this in favor of #3438. When #3390 merged, it caused irreparable merge conflicts on this PR which even when accepting in their entirety caused this PR to break in several ways. I decided to re-branch off of develop to see if the same issues still occurred and they did not. It seems there were some conflicting packages in the |
Summary of Changes
Pull request closes N/A
How to Test
List the steps to test the PR
These steps are generic, please adjust as necessary.
Save with Encoding
. Choose a few encodings and submit each file as you change the encoding.UTF-8 with BOM
,UTF-16 LE
, andUTF-16 BE
.Deliverables
More details on how deliverables herein are assessed included here.
Deliverable 1: Accepted Features
Checklist of ACs:
lfrohlich
and/oradpennington
confirmed that ACs are met.Deliverable 2: Tested Code
CodeCov Report
comment in PR)CodeCov Report
comment in PR)Deliverable 3: Properly Styled Code
Deliverable 4: Accessible
iamjolly
andttran-hub
using Accessibility Insights reveal any errors introduced in this PR?Deliverable 5: Deployed
Deliverable 6: Documented
Deliverable 7: Secure
Deliverable 8: User Research
Research product(s) clearly articulate(s):