-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated File Upload to Auto Encode to UTF-8 #3438
base: develop
Are you sure you want to change the base?
Conversation
… always resolving with the loaded file
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3438 +/- ##
===========================================
- Coverage 91.40% 91.37% -0.03%
===========================================
Files 302 302
Lines 8679 8689 +10
Branches 643 643
===========================================
+ Hits 7933 7940 +7
- Misses 625 628 +3
Partials 121 121
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working as expected, and i appreciate you cleaning up the functions a bit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…TANF-app into 2854-utf8-file-encode
Even though all of the tests are passing, Jest is returning a status code of |
Summary of Changes
Pull request closes #2854
How to Test
List the steps to test the PR
These steps are generic, please adjust as necessary.
Save with Encoding
. Choose a few encodings and submit each file as you change the encoding.UTF-8 with BOM
,UTF-16 LE
, andUTF-16 BE
.Deliverables
More details on how deliverables herein are assessed included here.
Deliverable 1: Accepted Features
Checklist of ACs:
lfrohlich
and/oradpennington
confirmed that ACs are met.Deliverable 2: Tested Code
CodeCov Report
comment in PR)CodeCov Report
comment in PR)Deliverable 3: Properly Styled Code
Deliverable 4: Accessible
iamjolly
andttran-hub
using Accessibility Insights reveal any errors introduced in this PR?Deliverable 5: Deployed
Deliverable 6: Documented
Deliverable 7: Secure
Deliverable 8: User Research
Research product(s) clearly articulate(s):