Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update web3.py, eth-tester #1153

Merged
merged 3 commits into from
Aug 13, 2019
Merged

Conversation

palango
Copy link
Contributor

@palango palango commented Aug 7, 2019

Next try at what #876 was doing.

There is still a test failure, but I'll report that upstream.

@palango
Copy link
Contributor Author

palango commented Aug 7, 2019

Question posted here: ethereum/web3.py#1412

@codecov
Copy link

codecov bot commented Aug 7, 2019

Codecov Report

Merging #1153 into master will decrease coverage by 0.13%.
The diff coverage is 85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1153      +/-   ##
==========================================
- Coverage   81.18%   81.05%   -0.14%     
==========================================
  Files          21       21              
  Lines        1446     1446              
  Branches      188      188              
==========================================
- Hits         1174     1172       -2     
  Misses        230      230              
- Partials       42       44       +2
Impacted Files Coverage Δ
raiden_contracts/utils/pending_transfers.py 96% <ø> (ø) ⬆️
raiden_contracts/utils/mint_tokens.py 0% <0%> (ø) ⬆️
raiden_contracts/utils/token_ops.py 0% <0%> (ø) ⬆️
raiden_contracts/deploy/contract_verifier.py 85.13% <100%> (-1.36%) ⬇️
raiden_contracts/deploy/contract_deployer.py 90% <100%> (ø) ⬆️
raiden_contracts/utils/proofs.py 92.3% <100%> (ø) ⬆️
raiden_contracts/deploy/__main__.py 93.93% <100%> (ø) ⬆️
raiden_contracts/contract_manager.py 96.42% <100%> (ø) ⬆️
raiden_contracts/utils/transaction.py 77.77% <100%> (ø) ⬆️
raiden_contracts/utils/logs.py 89.56% <100%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d97b8f6...7944128. Read the comment docs.

Copy link
Contributor

@pirapira pirapira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants