Integrate Synapse into dev requirements #3172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulope
force-pushed
the
feature/synapse_py3
branch
from
faee5e1 to
0f062e4
Compare
ulope
force-pushed
the
feature/synapse_py3
branch
5 times, most recently
from
fed9cbf to
7f73635
Compare
This was referenced Jan 16, 2019
ulope
force-pushed
the
feature/synapse_py3
branch
3 times, most recently
from
a4a375b to
a526e64
Compare
|
Reviewing this now |
jomuel
approved these changes
Jan 17, 2019
andrevmatos
reviewed
Jan 18, 2019
andrevmatos
reviewed
Jan 18, 2019
andrevmatos
reviewed
Jan 18, 2019
andrevmatos
reviewed
Jan 18, 2019
andrevmatos
approved these changes
Jan 18, 2019
Merged
Fixes raiden-network#1590, fixes raiden-network#2906 - Switch to using Synapse under Python 3, thereby removing the need to install a separate Python 2 virtualenv to be able to run the Matrix tests. - Restructure the Matrix related fixtures to allow starting multiple matrix servers in a local federation. - Update the `get_free_port` fixture to be more reliable - Remove some port related configuration options, since they are no longer needed with the above change
ulope
force-pushed
the
feature/synapse_py3
branch
from
a526e64 to
d182af8
Compare
15 tasks
|
For the |
|
No reason, just seemed a bit easier for a 'ci only' option. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1590, fixes #2906
to install a separate Python 2 virtualenv to be able to run the
Matrix tests.
multiple matrix servers in a local federation.
get_free_portfixture to be more reliablesince they are no longer needed with the above change