-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CircleCI coverage #3267
CircleCI coverage #3267
Conversation
0e8c72e
to
3637667
Compare
5ad6c1a
to
70aa666
Compare
Codecov Report
@@ Coverage Diff @@
## master #3267 +/- ##
=========================================
Coverage ? 74.81%
=========================================
Files ? 94
Lines ? 12150
Branches ? 1689
=========================================
Hits ? 9090
Misses ? 2443
Partials ? 617 Continue to review full report at Codecov.
|
22417a0
to
6b74c51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, can we also get a quick look from @ulope?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. One small change required.
@@ -473,6 +487,15 @@ workflows: | |||
- prepare-python-3.6 | |||
- build-synapse | |||
|
|||
- test: | |||
name: test-fuzz-3.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both this and test-fuzz-3.7
needs to be referenced in the requires
section of the finalize
step in the workflow definitions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, I added the fuzz tests to the nightly build too.
@@ -551,6 +574,15 @@ workflows: | |||
- prepare-python-3.7 | |||
- build-synapse | |||
|
|||
- test: | |||
name: test-fuzz-3.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above.
<< *job-template-test | ||
env: | ||
- TEST='raiden/tests/fuzz' | ||
- TRANSPORT_OPTIONS='--hypothesis-show-statistics' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm not the cleanest way to 'abuse' the TRANSPORT_OPTIONS here but I guess since travis is on the way out in any case it doesn't matter that much.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's what I thought, otherwise I would have renamed them to ADDITIONAL_OPTIONS
or something.
bb706ae
to
75b507f
Compare
coverage
on all testsMerge this after #3172, which should fix performance issues when testing with matrix. Builds using
coverage
are somewhat flaky at the moment since the integration tests with matrix transport sometimes time out.Closes #3071