Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircleCI coverage #3267

Merged
merged 2 commits into from
Jan 18, 2019
Merged

CircleCI coverage #3267

merged 2 commits into from
Jan 18, 2019

Conversation

jomuel
Copy link
Contributor

@jomuel jomuel commented Jan 14, 2019

  • seperate jobs for fuzz tests, instead of running them together with the unit tests
  • use coverage on all tests
  • introduce CodeCov.io for coverage reports.

Merge this after #3172, which should fix performance issues when testing with matrix. Builds using coverage are somewhat flaky at the moment since the integration tests with matrix transport sometimes time out.

Closes #3071

@jomuel jomuel force-pushed the issue-3072 branch 10 times, most recently from 5ad6c1a to 70aa666 Compare January 18, 2019 10:25
@codecov-io
Copy link

codecov-io commented Jan 18, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@25d2816). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3267   +/-   ##
=========================================
  Coverage          ?   74.81%           
=========================================
  Files             ?       94           
  Lines             ?    12150           
  Branches          ?     1689           
=========================================
  Hits              ?     9090           
  Misses            ?     2443           
  Partials          ?      617

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25d2816...e9f8bf3. Read the comment docs.

@jomuel jomuel force-pushed the issue-3072 branch 2 times, most recently from 22417a0 to 6b74c51 Compare January 18, 2019 12:06
Copy link
Contributor

@rakanalh rakanalh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, can we also get a quick look from @ulope?

Copy link
Collaborator

@ulope ulope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One small change required.

@@ -473,6 +487,15 @@ workflows:
- prepare-python-3.6
- build-synapse

- test:
name: test-fuzz-3.6
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both this and test-fuzz-3.7 needs to be referenced in the requires section of the finalize step in the workflow definitions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, I added the fuzz tests to the nightly build too.

@@ -551,6 +574,15 @@ workflows:
- prepare-python-3.7
- build-synapse

- test:
name: test-fuzz-3.7
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above.

<< *job-template-test
env:
- TEST='raiden/tests/fuzz'
- TRANSPORT_OPTIONS='--hypothesis-show-statistics'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm not the cleanest way to 'abuse' the TRANSPORT_OPTIONS here but I guess since travis is on the way out in any case it doesn't matter that much.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I thought, otherwise I would have renamed them to ADDITIONAL_OPTIONS or something.

@jomuel jomuel force-pushed the issue-3072 branch 4 times, most recently from bb706ae to 75b507f Compare January 18, 2019 14:15
@ulope ulope changed the title CircleCI integration CircleCI coverage Jan 18, 2019
@jomuel jomuel merged commit dbffbe5 into raiden-network:master Jan 18, 2019
@jomuel jomuel deleted the issue-3072 branch January 18, 2019 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Codecov in Circle CI
4 participants