Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 6.1 compatibility #121

Closed
walski opened this issue Nov 23, 2020 · 2 comments
Closed

Rails 6.1 compatibility #121

walski opened this issue Nov 23, 2020 · 2 comments

Comments

@walski
Copy link

walski commented Nov 23, 2020

Steps to reproduce

  • Use gem 'rails', '~> 6.1.rc1' and gem 'ros-apartment', require: 'apartment' in the same application

Expected behavior

It lets you install the bundle.

Actual behavior

It fails due to the current strict requirement of a Rails version < 6.1

Proposed Change

Specs run fine when relaxing the Rails version requirement to < 6.2 in the gemspec. Would love to open a PR with this change if that is ok with current release standards. Cheers!

@walski
Copy link
Author

walski commented Nov 23, 2020

This is really all there is to it: walski@1353b8d

@rpbaltazar
Copy link
Contributor

#122

rpbaltazar added a commit that referenced this issue Dec 16, 2020
Prepare Release - 2.8.0

- Resolves #98 - Trying to generate an automatic changelog - #99
- Resolves #86 - Fixes seeding errors - #87
- Resolves #66 - Uses a transaction to create a tenant - #69
- Resolves #121 - Relaxes dependencies to allow rails 6.1 - #122
- Resolves #123 - When tests run in a transaction, new tenants in tests fail to create - #124
- Reverted unsafe initializer - #118
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants