Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tenant creation in transaction makes some test cases fail #123

Closed
rpbaltazar opened this issue Dec 15, 2020 · 1 comment · Fixed by #124
Closed

Tenant creation in transaction makes some test cases fail #123

rpbaltazar opened this issue Dec 15, 2020 · 1 comment · Fixed by #124

Comments

@rpbaltazar
Copy link
Contributor

Steps to reproduce

Run the test suite with use_transactional_fixtures set to true. Creating a new tenant in a test will raise an exception because a transaction is already in place

Expected behavior

Should pass the tests and not raise exception

  • Database: (Tell us what database and its version you use.)

postgresql 12.4

  • Apartment version:

development branch

  • Apartment config (in config/initializers/apartment.rb or so):

    • use_schemas: true

  • Rails (or ActiveRecord) version:

6.0.3.4

  • Ruby version:

2.7.1
rpbaltazar added a commit that referenced this issue Dec 15, 2020
@rpbaltazar
[#123] check if there is an open transaction and if yes, dont create …
54a5ed1 
…a new one
@rpbaltazar rpbaltazar mentioned this issue Dec 15, 2020
Merged
rpbaltazar added a commit that referenced this issue Dec 15, 2020
@rpbaltazar
[#123] check if there is an open transaction and if yes, dont create …
5812824 
…a new one
rpbaltazar added a commit that referenced this issue Dec 16, 2020
@rpbaltazar
[#123] check if there is an open transaction and if yes, dont create …
9a9308e 
…a new one
@rpbaltazar rpbaltazar mentioned this issue Dec 16, 2020
Merged
@rpbaltazar
Copy link
Contributor Author

Caused by #66

rpbaltazar added a commit that referenced this issue Dec 16, 2020
@rpbaltazar
Merge pull request #126 from rails-on-services/development
8964442 
Prepare Release - 2.8.0

- Resolves #98 - Trying to generate an automatic changelog - #99
- Resolves #86 - Fixes seeding errors - #87
- Resolves #66 - Uses a transaction to create a tenant - #69
- Resolves #121 - Relaxes dependencies to allow rails 6.1 - #122
- Resolves #123 - When tests run in a transaction, new tenants in tests fail to create - #124
- Reverted unsafe initializer - #118
@dlupu dlupu mentioned this issue Jan 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

check if there is an open transaction rails-on-services/apartment
1 participant
@rpbaltazar