-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI] Improve App background statuses feedback #1217
Comments
I was wondering if it would make sense to write a JSON file with status information to disk (in the log directory) every time the status changes? To avoid race conditions between writing and reading the file, the data should always be written to a temp file, which then gets renamed to the canonical name. If the rename fails, the error is ignored because the canonical file is probably locked by somebody reading it. This file could both be used to wait until RD reaches a specific state, and also for inspecting the last state when the app hangs or crashes. Not sure if this would be helpful for CI and/or QA. PS: I just noticed that this issue has a |
I like the idea to have a centralized feature that we can rely on in order to check if the app is health. IT will be helpful for everyone :) In terms of CI/QA, your solution seems fine and there's no restrictions from the test framework. |
I think it would make sense to fit in a red/yellow/green status indicator. I imagine that it could include a dropdown with a status check for each of our services, so that we could easily see where a warning or failure occurred. Making use of a status file could provide us with all the information we need to get a quick heads up about the state of our system, while clicking on any given service could open the respective log for further troubleshooting. |
That's another really good solution! Thanks for sharing your thoughts @rak-phillip |
Tagging another feature request on the same matter: #1354 |
Since we are talking about a GUI status indicator, there is another situation that I would like to get a prominent visual alert for: when the current kubernetes context is not "rancher-desktop". This can happen e.g. when the user works with their EKS cluster one day, boots up the workstation the next day, starts Rancher Desktop, and want to interact with the cluster using I haven't thought this through yet, but we might eventually have a similar situation with Docker contexts, so any alerting mechanism we design should be extensible to that as well. |
I've been meaning to file a bug about automatically switching contexts. I haven't checked to see if docker desktop does this when one enables kubernetes, but in general we found rancher changing the default context from one we were using to be surprising. If there isn't a selected context, it's fine to select a new one (=rancher-desktop), but otherwise, my default expectation would be to leave it alone. |
Preflight Checklist
Problem Description
Relying on
progress
bar to make sure that all background services are up/running could be a danger zone.If something went really bad and the process bar was detached (hidden) and you than you notice something isn't working...
you might need to dig into the logs, access the VM and do a bunch of manual process to double check if everything is working.
Proposed Solution
e.g: K8s cluster healthz check ( kubectl healthz curl -k https://localhost:6443/livez?verbose)
Additional Information
Motivator:
Currently our E2E tests rely on
.progress
class element. We're assuming after the progress bar being detached from the page, it means that all services were properly loaded (k3s, k8s api, VM, and etc).So far, it is working, but it will be much better to have feature that we can ensure all the services were loaded properly or not, without rely on a HTML element (visible/hidden states).
The text was updated successfully, but these errors were encountered: