wsl-helper: close /attach on /wait exit. #1354
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, running interactive docker sessions does not quit correctly
when the container exits; instead, the user must press a key to let the
client notice the end of the connection. This does not happen on Linux (in
WSL). The underlying API (/containers/{id}/wait) appears to work correctly
however; the connection closes correctly. As a workaround, forcefully
close any /containers/{id}/attach connections when a corresponding /wait
returns.
Signed-off-by: Mark Yen <[email protected]>
1 task
|
Hmm, this doesn't help with I'll have to try to fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, running interactive docker sessions does not quit correctly when the container exits; instead, the user must press a key to let the client notice the end of the connection. This does not happen on Linux (in WSL). The underlying API (
/containers/{id}/wait) appears to work correctly however; the connection closes correctly. As a workaround, forcefully close any/containers/{id}/attachconnections when a corresponding/waitreturns.Fixes #1171.