Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable menu items during snapshot process #5998

Open
rak-phillip opened this issue Nov 17, 2023 · 3 comments
Open

Disable menu items during snapshot process #5998

rak-phillip opened this issue Nov 17, 2023 · 3 comments

Comments

@rak-phillip
Copy link
Contributor

rak-phillip commented Nov 17, 2023

Users can potentially quit Rancher Desktop while a snapshot operation(create/restore) is in progress.

This behavior is always present in macOS but can also happen on Windows and Linux, depending on environment customization.

Proposed Solution

Disable menu items on all platforms(macOS, Windows, Linux) while a snapshot operation is active.

macOS

  • Settings...
  • Quit Rancher Desktop

Windows & Linux

  • Preferences
  • Exit
@jandubois
Copy link
Member

I don't think quitting or exiting should be completely disabled; they should (try to) cancel the current snapshot operation (once that functionality is implemented) and then still shut down the VM gracefully.

@rak-phillip
Copy link
Contributor Author

Sounds good, maybe this issue will become solely focused on disabling preferences and then we can focus on the quitting/exiting behavior in #5999

@mook-as
Copy link
Contributor

mook-as commented Dec 15, 2023

FWIW, I can reproduce on Windows via:

  1. Start a snapshot (restore, in my case)
  2. Using the tray menu, select Open main window
  3. Use the keyboard shortcuts (Alt+F, etc.)

The keyboard shortcuts are unavailable until step 2 was completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants