Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable quit in tray during snapshot process #5988

Conversation

rak-phillip
Copy link
Contributor

@rak-phillip rak-phillip commented Nov 16, 2023

This adds an id for the "quit" context menu item in the tray menu and filtering by using array methods.

closes #5854

This adds an id for the "quit" context menu item in the tray menu and filtering by using array methods.

Signed-off-by: Phillip Rak <[email protected]>
@rak-phillip rak-phillip requested a review from mook-as November 16, 2023 21:48
Copy link
Contributor

@mook-as mook-as left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine, but do note that people can still quit via the dock icon, IIRC. And there's also the main menu.

@rak-phillip
Copy link
Contributor Author

That's fine, but do note that people can still quit via the dock icon, IIRC. And there's also the main menu.

The scope of the issue covers the tray menu, but I can investigate and expand this PR to the dock icon.. I don't think we need to concern ourselves with the main menu, as interactions with it should be disabled altogether during snapshot operations.

@mook-as
Copy link
Contributor

mook-as commented Nov 16, 2023

Nah, it's fine to do things in a follow-up PR; I just wanted to note that so you're aware (since you're in a better position to know what other things need to be done in the area).

@jandubois
Copy link
Member

jandubois commented Nov 17, 2023

I don't think we need to concern ourselves with the main menu, as interactions with it should be disabled altogether during snapshot operations.

This does not appear to be the case, at least on macOS. The application menu remains fully functional during the operation. I'm also not sure how the menu should be disabled; it would be done by disabling individual menu items. I'm not sure if you should ever disable the "File | Quit" menu entry, or if this should just cancel the snapshot operation and then exit the app? (I realize that "Cancel" is not yet implemented, but let's assume it is).

But this should be a separate issue. Keep this one to the tray functionality!

@rak-phillip
Copy link
Contributor Author

This does not appear to be the case, at least on macOS

Of course, the global menu on macOS wouldn't be blocked by any dialogs.. I created two issues so that we can follow-up and address these changes

#5999
#5998

@rak-phillip rak-phillip merged commit 986a836 into rancher-sandbox:main Nov 17, 2023
@rak-phillip rak-phillip deleted the bugfix/5854-snapshots-disable-quit branch November 17, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows 11: Can quit RD while creating/restoring a snapshot
3 participants