Add PerClusterResourceCounts to GitRepo status #3209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aruiz14
force-pushed
the
per-cluster-resourcecounts
branch
from
a722192 to
df8e482
Compare
|
@aruiz14 - this is still flagged as draft 🤔 |
Yes. It depends on another PR being reviewed, but Github it's not nice showing stacked PRs |
aruiz14
force-pushed
the
per-cluster-resourcecounts
branch
from
df8e482 to
ace6f56
Compare
weyfonk
reviewed
Jan 17, 2025
aruiz14
force-pushed
the
per-cluster-resourcecounts
branch
from
ace6f56 to
6e42b0c
Compare
aruiz14
force-pushed
the
per-cluster-resourcecounts
branch
from
6e42b0c to
aa1ea74
Compare
weyfonk
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refers to #3186
This PR extends the current public API to add a new field to every GitRepoStatus:
perClusterResourceCounts, which is a map of related resource counts by cluster ID.It uses the new status field added to BundleDeploymentStatus by Add resourceCounts and incomplete state to BundleDeploymentStatus #3203
In addition, it removes the dependency on the GitRepo's
status.summaryfield, which is just a pre-calculated summary of BundleDeployment statuses, which was then aggregated and used to assign a resource state. Instead, I've changed it to use the actual per-BundleDeployment state since it's available.