Rework how resources are calculated #3238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aruiz14
commented
Jan 22, 2025
Comment on lines
+177
to
+178
| // "Ready" states are currently omitted | ||
| if entry.State == "Ready" { | ||
| continue | ||
| } |
There was a problem hiding this comment.
When I mentioned in the description about perClusterState being opinionated, this is one of the causes: Ready resources are omitted from this view (and that forces the UI to use BundleDeployments for displaying GitRepo resources BTW). If we wanted to change that, it would be as simple as removing these lines.
weyfonk
reviewed
Jan 23, 2025
aruiz14
force-pushed
the
rework-gitrepo-status-resources
branch
from
f06827f to
4f0cde5
Compare
|
Would we need to adapt UI for this ? |
@kkaempf no, no change is needed. It only changes how the info is calculated internally, while still producing the same result |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refers to #3186
This PR concludes the work started on #3203 and #3209, by refactoring how the
status.resources(and especiallyperClusterState) are calculated.The goal of this refactor is to keep all the information accessible, while still producing the same opinionated representation. This will allow to later change the format in an easier way, or adding new fields from the same information (e.g.
PerClusterResources).