Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replace unapproved GH Actions with approved ones #477

Merged
merged 1 commit into from
May 23, 2024

Conversation

yiannistri
Copy link
Contributor

What this PR does / why we need it:

Replace unapproved GH Actions with approved ones. To enhance security, the 3rd-party GH Action used to install kind is pinned to a commit SHA. Note that dependabot will update both the commit SHA and the human-readable value next to it.

Which issue(s) this PR fixes
Issue rancher/highlander#89

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests
  • backport needed

@yiannistri yiannistri added github_actions Pull requests that update GitHub Actions code area/ci labels May 22, 2024
@yiannistri yiannistri marked this pull request as ready for review May 22, 2024 13:00
@yiannistri yiannistri requested a review from a team as a code owner May 22, 2024 13:00
@yiannistri yiannistri force-pushed the 89-migrate-gha-main branch from ef40a34 to 1e03735 Compare May 22, 2024 13:30
Copy link
Contributor

@salasberryfin salasberryfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yiannistri. LGTM.

@mjura mjura merged commit 9cf446e into rancher:main May 23, 2024
7 checks passed
@yiannistri yiannistri deleted the 89-migrate-gha-main branch May 23, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants